Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear size function #296

Closed
noscode opened this issue May 31, 2021 · 4 comments
Closed

Linear size function #296

noscode opened this issue May 31, 2021 · 4 comments
Milestone

Comments

@noscode
Copy link
Contributor

noscode commented May 31, 2021

I have added demes to GADMA to use it for the alternative representation of the demographic histories. I also used demesdraw for drawing. I have faced to one problem though. By default, GADMA uses three types of size functions: constant, exponential and linear. Unfortunately, demes does not support linear function right now and GADMA has to print warnings when it try to use demes for the demographic history with linear size change. It is not very big deal but it would be very cool to get support of linear functions.

I found some discussion here #262: additional size function support was planned in the future. What do you think about adding linear now? If you like I can implement it as then GADMA will be able to use demes for any history and I really like it to do so.

@grahamgower
Copy link
Member

I have added demes to GADMA to use it for the alternative representation of the demographic histories. I also used demesdraw for drawing.

Oh, wow! Cool!

I have faced to one problem though. By default, GADMA uses three types of size functions: constant, exponential and linear. Unfortunately, demes does not support linear function right now and GADMA has to print warnings when it try to use demes for the demographic history with linear size change. It is not very big deal but it would be very cool to get support of linear functions.

I found some discussion here #262: additional size function support was planned in the future. What do you think about adding linear now? If you like I can implement it as then GADMA will be able to use demes for any history and I really like it to do so.

Yes, this sounds good. It would be great if you could add in the bits needed for size_function == "linear". Probably this doesn't need much, just a few lines plus the tests.

I suppose we should keep the current behaviour where if size_function is not specified in a YAML, but start_size != end_size, then the size_function defaults to "exponential".

Any other thoughts @apragsdale?

@noscode
Copy link
Contributor Author

noscode commented Jun 1, 2021

I suppose we should keep the current behaviour where if size_function is not specified in a YAML, but start_size != end_size, then the size_function defaults to "exponential".

I agree, I was thinking about the same thing.

@jeromekelleher
Copy link
Member

This is great - we should update the spec also.

@grahamgower
Copy link
Member

Closed by #310.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants