Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View plot in editor space #2270

Closed
timtmok opened this issue Feb 15, 2024 · 8 comments
Closed

View plot in editor space #2270

timtmok opened this issue Feb 15, 2024 · 8 comments
Assignees
Labels
area: plots Issues related to Plots category. enhancement New feature or request theme: app builder

Comments

@timtmok
Copy link
Contributor

timtmok commented Feb 15, 2024

Add a way to allow a user to view a plot as an editor. This allows a larger view without altering the size of the plots pane and leverages the editor's ability to float as its own window or tile along other editors/plots.

@petetronic petetronic added this to the Public Beta 2024 Q2 milestone Feb 15, 2024
@wesm wesm added the area: plots Issues related to Plots category. label Feb 29, 2024
@jmcphers
Copy link
Collaborator

Requested (more or less) by beta user: https://github.com/posit-dev/positron-beta/discussions/122

@juliasilge
Copy link
Contributor

I have been doing some prep for teaching a workshop, and I really want this feature.

@jmcphers
Copy link
Collaborator

Relevant Mastodon thread:

The only weird thing is no zoom option for plotting.

https://mastodon.online/@[email protected]/112695382560885990

@seeM
Copy link
Contributor

seeM commented Jul 5, 2024

Sort of requested in #3884.

@nstrayer
Copy link
Contributor

I think as long as we have a really good encapsulation of the IPositronPlotClient class it should be relatively straightforward to write an EditorPane/EditorInput class that can act as the front-end.

Work done for #1713 will probably make this easier as it will involve making the front-end as stateless as possible.

@factorialmap
Copy link

In RStudio there is a very useful option to show data/plots/viewer/console without having to split panels, it just expands the panels using shortcut keys.

Tools>Modify Keyboard Shortcuts>Zoom. It's really fast.

I think it might be really cool if we had that on the Positron.

expand_panels.mp4

@juliasilge
Copy link
Contributor

I'll start some QA notes for the initial version of this! 🎉

QA Notes

  • The new ability to open a plot in editor space should be behind a feature flag where the default is off.

@testlabauto
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2024.09.0-27
OS Version          : OSX

Test scenario(s)

Open in editor works well. No controls yet in editor I assume is expected.

Link(s) to TestRail test cases run or created:
N/A

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: plots Issues related to Plots category. enhancement New feature or request theme: app builder
Projects
None yet
Development

No branches or pull requests

9 participants