Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Explorer tabs not restored on reload/resume tab #3172

Open
Tracked by #1617
jmcphers opened this issue May 16, 2024 · 1 comment
Open
Tracked by #1617

Data Explorer tabs not restored on reload/resume tab #3172

jmcphers opened this issue May 16, 2024 · 1 comment
Labels
area: data explorer Issues related to Data Explorer category. area: workbench Issues related to Workbench category. bug Something isn't working

Comments

@jmcphers
Copy link
Collaborator

Positron Version:

Positron Version: 2024.05.0 (Universal) build 1255
Code - OSS Version: 1.89.0
Commit: a60c905e786adc4cfccae02d538c5a2ac5ad9b01
Date: 2024-05-16T03:42:49.370Z
Electron: 28.2.8
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Darwin arm64 23.4.0

Steps to reproduce the issue:

  1. Open two editors and two data explorer windows.
  2. Use the Developer -> Reload Window command.

The data explorer windows disappear and aren't restored on reload.

What did you expect to happen?

The data explorers should be restored.

Just as we do with Plots, we should ask the backend to list its open comms to discover the set of data explorers that are still open, and restore tabs for each one.

This is an important feature for Posit Workbench; without it, you'll lose all your open explorers (and any filter/sort state you accumulated in them) if you close your browser tab.

@jmcphers jmcphers added bug Something isn't working area: data explorer Issues related to Data Explorer category. labels May 16, 2024
@jthomasmock jthomasmock added this to the Release Candidate milestone May 19, 2024
@jthomasmock
Copy link
Contributor

Putting this into release candidate as we prep for Workbench integration.

@sharon-wang sharon-wang added the area: workbench Issues related to Workbench category. label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: data explorer Issues related to Data Explorer category. area: workbench Issues related to Workbench category. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants