Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade repo to use Node 20 everywhere #1206

Closed
dotNomad opened this issue Mar 26, 2024 · 7 comments · Fixed by #1804
Closed

Upgrade repo to use Node 20 everywhere #1206

dotNomad opened this issue Mar 26, 2024 · 7 comments · Fixed by #1804
Assignees
Labels
Milestone

Comments

@dotNomad
Copy link
Collaborator

dotNomad commented Mar 26, 2024

Node 18 LTS active support ended in Oct 2023. However we still need to use Node 18 because Electron 28 (what VSCode uses) is still running Node 18.

When VSCode upgrades Electron to version 29 we can use Node 20 everywhere.

References

@dotNomad dotNomad changed the title Upgrade repo to use node 20 everywhere Upgrade repo to use Node 20 everywhere Mar 26, 2024
@mmarchetti
Copy link
Collaborator

microsoft/vscode#208959

@dotNomad
Copy link
Collaborator Author

microsoft/vscode#208959

Thank you! I was hunting for an issue like when I made this one, turns out I was just ahead of the game a bit.

@dotNomad
Copy link
Collaborator Author

Looks like microsoft/vscode#210467 (comment) was closed up. The upcoming release of VSCode may be on Electron 29.

@mmarchetti
Copy link
Collaborator

Let's find out what VSCode base the Positron beta will build from.

@dotNomad
Copy link
Collaborator Author

Let's find out what VSCode base the Positron beta will build from.

Positron just built off of April 2024 (version 1.89). When they cut beta we can take a look. Great idea 👍

@dotNomad dotNomad added this to the Beta (v1.0.beta1) milestone Jun 6, 2024
@dotNomad dotNomad self-assigned this Jun 6, 2024
@dotNomad
Copy link
Collaborator Author

dotNomad commented Jun 7, 2024

With the scripts updated to node 20, and the types updated this looks done. I did notice our tsconfig extension was still node18, and addressed that in #1813

@dotNomad
Copy link
Collaborator Author

dotNomad commented Jun 7, 2024

Moving this back to in-progress, and to Beta 2. I noticed #1813 and some github workflows that were still using node-version 18. Will update those.

The changelog doesn't need to be updated because this wasn't listed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants