Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should update pyright #126

Closed
wch opened this issue Apr 24, 2024 · 1 comment
Closed

Should update pyright #126

wch opened this issue Apr 24, 2024 · 1 comment

Comments

@wch
Copy link
Collaborator

wch commented Apr 24, 2024

The version of pyright that is used in shinylive is based on a fork from Microbit, and it is getting somewhat out of date and contains a few bugs that have been fixed in more recent versions of pyright.

It would be good to replace the Microbit build of pyright with one based on the main branch of pyright. Some useful information here:

microsoft/pyright#3222
https://github.com/microbit-foundation/pyright/blob/microbit/THIS_FORK.md

@wch
Copy link
Collaborator Author

wch commented May 31, 2024

Done in #138.

@wch wch closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant