Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should make target dist work without making "all" before #127

Open
TobiasFellinger opened this issue Apr 30, 2024 · 0 comments
Open

should make target dist work without making "all" before #127

TobiasFellinger opened this issue Apr 30, 2024 · 0 comments

Comments

@TobiasFellinger
Copy link

Is the make target dist intended to be built without making all before? I tried building the dist files, to test deploying a shinylive app with the newest assets. It seems to be necessary to build the make target all before making dist.

If this is intended behavior, please clarify in the build instructions in the README.md or if not add the necessary dependencies to the dist target.

make submodules
make dist

Fails with error:

node_modules/.bin/tsx scripts/build.ts
make: node_modules/.bin/tsx: Command not found
make: *** [Makefile:203: buildjs] Error 127

Works:

make submodules
make all
make dist

All in all, the build process is really well setup and building worked quickly, so this is probably a minor issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant