Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 not working due to babel #63

Open
ramiel opened this issue Jun 28, 2019 · 3 comments
Open

v1 not working due to babel #63

ramiel opened this issue Jun 28, 2019 · 3 comments

Comments

@ramiel
Copy link

ramiel commented Jun 28, 2019

Why is version 1 based on babel? There's no strange code in it that needs to be transpiled. At the moment when the v1 is imported this error happens:

 ReferenceError: regeneratorRuntime is not defined

I'm also seeing that v1 is starving and I would be happy to help. Is there a list of issues I can work on? I can do some of the point in the spec, but some are question more than todos. Let me know.

@tim-phillips
Copy link
Collaborator

Actually the v0 is based on babel as well, it's used for the tests. But I don't see that error. You've done yarn install?

Please help! We need people who understand the spec and can write issues that bring the lib to spec.

@ramiel
Copy link
Author

ramiel commented Sep 11, 2019

Ok, I'll try to find some time to propose some PR to see the new version ready

@tim-phillips
Copy link
Collaborator

tim-phillips commented Sep 27, 2019

I upgraded in a project of mine and got the same error. The build step does build with babel even though we don't need it other than tests. Maybe its for the CI?

edit: I guess the error is only in v1.0.0-alpha.2, which is why I wasn't seeing it. Must have triggered something in that update.

@pudgereyem pudgereyem mentioned this issue May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants