fix(index): continue watching after dependency {Error}
#332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenbrent
requested review from
alexander-akait and
michael-ciniawsky
as code owners
michael-ciniawsky
changed the title
{Error}
michael-ciniawsky
requested changes
Feb 1, 2018
test/helpers/fileChange.js
Outdated
| @@ -0,0 +1,31 @@ | |||
| const path = require('path') | |||
There was a problem hiding this comment.
test/helpers/fileChange => test/helpers/fs
test/helpers/fileChange.js
Outdated
| const wf = promisify(writeFile) | ||
| const rm = promisify(unlink) | ||
|
|
||
| function readCssFile (name) { |
test/helpers/fileChange.js
Outdated
| const rm = promisify(unlink) | ||
|
|
||
| function readCssFile (name) { | ||
| const fileName = path.join(__dirname, '../fixtures', name) |
test/helpers/fileChange.js
Outdated
| const fileName = path.join(__dirname, '../fixtures', name) | ||
|
|
||
| return rf(fileName) | ||
| .then(c => c.toString()) |
test/helpers/fileChange.js
Outdated
| .then(c => c.toString()) | ||
| } | ||
|
|
||
| function writeCssFile (name, contents) { |
test/loader.test.js
Outdated
| (stats) => { | ||
| const { err, src } = loader(stats) | ||
| expect(src).toMatchSnapshot() | ||
| expect(err.length).toEqual(0) |
There was a problem hiding this comment.
For each element in steps please
test/loader.test.js
Outdated
| var currentStep = 0 | ||
|
|
||
| const options = { | ||
| watching: true, |
There was a problem hiding this comment.
Either
const options = {
watch (err, stats, close) {
// ...handling
}
}or
const options = {
watch: {
handler (err, stats, close) { // ...handling }
}
}
test/loader.test.js
Outdated
| } | ||
| } | ||
|
|
||
| return webpack('css-watching/index.js', config, options) |
There was a problem hiding this comment.
css-watching => watch/watching (Fixtures)
test/helpers/compiler.js
Outdated
| if (err) reject(err) | ||
| if (options.watching) { | ||
| return new Promise((resolve, reject) => { | ||
| const c = compiler.watch({}, (err, stats) => { |
test/loader.test.js
Outdated
| loader: { | ||
| options: { | ||
| plugins: [require("postcss-import")], | ||
| watching: true |
There was a problem hiding this comment.
This should be config.watch(ing) instead of config.loader.watch(ing) ?
There was a problem hiding this comment.
Good catch, it isn't needed at all since I'm calling .watch() on the compiler.
|
That should cover everything. |
michael-ciniawsky
added
status: approved
and removed
pr: review
priority: high
status: pending
ci: ok
labels
There was a problem hiding this comment.
@zenbrent Thx. If you like PR the watch logic of yours to webpack-contrib/test-utils, otherwise I will 'steal this feature' 😛
|
Released in |
This was referenced Feb 2, 2018
This was referenced Mar 19, 2018
This was referenced Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you are watching a file that has dependancies (in my case, I was using the postcss-import module), and you save a file with a syntax error, the file watcher stops working.
This PR makes webpack continue watching in that case.
TypeSemVerIssuesCouldn't find an issue for this.
Checklist