make USE_PGXS=1 ends with error 1

[To4e]

Hi,
when I run "make USE_PGXS=1" it ends with "Error 1".

My env:

• psql (PostgreSQL) 9.6.0,
• gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4),
• centos-release-7-2.1511.el7.centos.2.10.x86_64

Here is the full text:

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -DLINUX_OOM_ADJ=0 -fpic -I. -I./ -I/usr/pgsql-9.6/include/server -I/usr/pgsql-9.6/include/internal -D_GNU_SOURCE -I/usr/include/lib
xml2  -I/usr/include  -c -o rumsort.o rumsort.c
In file included from /usr/pgsql-9.6/include/server/utils/probes.h:10:0,
                 from rumsort.c:136:
rumsort.c: In function ‘rum_tuplesort_begin_rum’:
rumsort.c:1160:9: error: ‘enforceUnique’ undeclared (first use in this function)
         enforceUnique,
         ^
rumsort.c:1159:2: note: in expansion of macro ‘TRACE_POSTGRESQL_SORT_START’
  TRACE_POSTGRESQL_SORT_START(INDEX_SORT,
  ^
rumsort.c:1160:9: note: each undeclared identifier is reported only once for each function it appears in
         enforceUnique,
         ^
rumsort.c:1159:2: note: in expansion of macro ‘TRACE_POSTGRESQL_SORT_START’
  TRACE_POSTGRESQL_SORT_START(INDEX_SORT,
  ^
/usr/pgsql-9.6/include/server/utils/probes.h:285:1: error: first argument to ‘__builtin_choose_expr’ not a constant
 DTRACE_PROBE5 (postgresql, sort__start, arg1, arg2, arg3, arg4, arg5)
 ^
rumsort.c:1159:2: note: in expansion of macro ‘TRACE_POSTGRESQL_SORT_START’
  TRACE_POSTGRESQL_SORT_START(INDEX_SORT,
  ^
/usr/pgsql-9.6/include/server/utils/probes.h:285:1: error: first argument to ‘__builtin_choose_expr’ not a constant
 DTRACE_PROBE5 (postgresql, sort__start, arg1, arg2, arg3, arg4, arg5)
 ^
rumsort.c:1159:2: note: in expansion of macro ‘TRACE_POSTGRESQL_SORT_START’
  TRACE_POSTGRESQL_SORT_START(INDEX_SORT,
  ^                                                                                                                                                                                                                                  [2/1925]
/usr/pgsql-9.6/include/server/utils/probes.h:285:1: error: first argument to ‘__builtin_choose_expr’ not a constant
 DTRACE_PROBE5 (postgresql, sort__start, arg1, arg2, arg3, arg4, arg5)
 ^
rumsort.c:1159:2: note: in expansion of macro ‘TRACE_POSTGRESQL_SORT_START’
  TRACE_POSTGRESQL_SORT_START(INDEX_SORT,
  ^
rumsort.c: In function ‘rum_tuplesort_begin_rumkey’:
rumsort.c:1193:9: error: ‘enforceUnique’ undeclared (first use in this function)
         enforceUnique,
         ^
rumsort.c:1192:2: note: in expansion of macro ‘TRACE_POSTGRESQL_SORT_START’
  TRACE_POSTGRESQL_SORT_START(INDEX_SORT,
  ^
/usr/pgsql-9.6/include/server/utils/probes.h:285:1: error: first argument to ‘__builtin_choose_expr’ not a constant
 DTRACE_PROBE5 (postgresql, sort__start, arg1, arg2, arg3, arg4, arg5)
 ^
rumsort.c:1192:2: note: in expansion of macro ‘TRACE_POSTGRESQL_SORT_START’
  TRACE_POSTGRESQL_SORT_START(INDEX_SORT,
  ^
/usr/pgsql-9.6/include/server/utils/probes.h:285:1: error: first argument to ‘__builtin_choose_expr’ not a constant
 DTRACE_PROBE5 (postgresql, sort__start, arg1, arg2, arg3, arg4, arg5)
 ^
rumsort.c:1192:2: note: in expansion of macro ‘TRACE_POSTGRESQL_SORT_START’
  TRACE_POSTGRESQL_SORT_START(INDEX_SORT,
  ^
/usr/pgsql-9.6/include/server/utils/probes.h:285:1: error: first argument to ‘__builtin_choose_expr’ not a constant
 DTRACE_PROBE5 (postgresql, sort__start, arg1, arg2, arg3, arg4, arg5)
 ^
rumsort.c:1192:2: note: in expansion of macro ‘TRACE_POSTGRESQL_SORT_START’
  TRACE_POSTGRESQL_SORT_START(INDEX_SORT,
  ^
make: *** [rumsort.o] Error 1

[za-arthur]

Hello,

Thank you for the issue. Fixed. Check please.

[To4e]

Yep, everything is fine, thank you very much. And special thanks for the operativeness.

[webbery]

Hi, I follow the rum installation make USE_PGXS=1 but get an error. My postgres installed with command 'apt-get install postgres-9.6'. gcc version is 5.4.0 and Ubuntu is 16.04. Detail error is:

Makefile:27: /usr/lib/postgresql/9.6/lib/pgxs/src/makefiles/pgxs.mk: No such file or directory
make: *** No rule to make target '/usr/lib/postgresql/9.6/lib/pgxs/src/makefiles/pgxs.mk'.  Stop

[za-arthur]

Hello,
Try to install postgresql-server-dev-9.6 package please. It would be nice if you give a feedback if it will help.

[webbery]

Yes, it works. thx.