Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Javascript shown in checkout when changing billing address #251

Closed
DuckThom opened this issue May 25, 2021 · 2 comments
Closed

[BUG] Javascript shown in checkout when changing billing address #251

DuckThom opened this issue May 25, 2021 · 2 comments

Comments

@DuckThom
Copy link

Current behaviour:

When the billing address is changed in the checkout, a large block of javascript code is displayed.

image

Expected behaviour:

The address is rendered normally.

Workaround:

Remove the call to _.values on the following line

https://github.com/tig-nl/postnl-magento2/blob/c5570db63943834b1dbb567cd9e1e2184ea93a5a/view/frontend/web/template/billing-address/details.html#L10

So it looks like this:

<text args="currentBillingAddress().street.join(', ')"/>

Notes:

This is a bug in Magento itself, however since the templates have been updated in 1.9.8 to match the Magento templates, this bug is now also present here. A patch was also released by Magento for this problem: https://support.magento.com/hc/en-us/articles/360058863531-MDVA-33289-Magento-patch-Javascript-in-address-at-checkout

Magento issue:

magento/magento2#26375

Versions:

  • PHP: 7.4
  • tig-nl/postnl-magento2: 1.9.8
  • Magento: 2.4.2
@tig-jeffreybranderhorst
Copy link
Contributor

Hi @DuckThom ,

Thank you for submitting this! We will pick this up. Thank you again!

Have a great day,
Jeffrey

@DuckThom
Copy link
Author

Fixed in 1.9.9 by commit c7e77ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants