Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review complexity metric checking #25

Open
pp-mo opened this issue Feb 21, 2022 · 1 comment
Open

Review complexity metric checking #25

pp-mo opened this issue Feb 21, 2022 · 1 comment

Comments

@pp-mo
Copy link
Owner

pp-mo commented Feb 21, 2022

I seem to have an ongoing problem with the flake complexity checking (McCabe).
It is perfectly true that many of the routines are rather over-complex, but the check only recently started failing.

This is simply disabled for now == line removed from setup.cfg, in #26

@pp-mo
Copy link
Owner Author

pp-mo commented Feb 21, 2022

To fix this properly, various sub-tasks of (e.g. and especially?) check.Checker.check_mesh_var should probably be moved to subsidiary methods.
But that in itself is going to make the flow + logic hard to read, since there is already a fairly logical division into separate checking routines. So it needs some careful thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant