Fix judgement counter not showing correct counts when spectating user mid-play #29914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
previously requested changes
Sep 18, 2024
Comment on lines
64
to
77
| // This flow is made to handle cases of watching from the middle of a replay / spectating session. | ||
| // | ||
| // Once we get an initial state, we can rely on `NewJudgement` and `JudgementReverted`, so | ||
| // as a preemptive optimisation, only do a full re-sync if we have all-zero counts. | ||
| bool hasCounts = false; | ||
|
|
||
| foreach (var r in results) | ||
| { | ||
| if (r.Value.ResultCount.Value > 0) | ||
| { | ||
| hasCounts = true; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
In testing on production, it appears that this breaks the PR, because it appears that the resets-from-replay-frame occur at the end of a frame bundle, at which point part of gameplay has been replayed and very likely incurred an actual judgement through the expected flows.
There was a problem hiding this comment.
I've applied a simple fix which looks good on paper and seems to work in initial testing. There's a brief period where counts won't be updated (until the first reset event) but I think this is okay.
bdach
reviewed
Sep 19, 2024
osu.Game/Screens/Play/HUD/JudgementCounter/JudgementCountController.cs
Outdated
Show resolved
Hide resolved
bdach
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29874
Test setup is ugly because the flow is ugly.