Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Nosey Parker GitHub Action #26

Open
bradlarsen opened this issue Feb 9, 2023 · 5 comments
Open

Add a Nosey Parker GitHub Action #26

bradlarsen opened this issue Feb 9, 2023 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed integration Related to integration with other systems

Comments

@bradlarsen
Copy link
Collaborator

Truffle Hog has a GitHub Action: https://github.com/marketplace/actions/trufflehog-oss
GitLeaks has a GitHub Action: https://github.com/gitleaks/gitleaks-action

Why not Nosey Parker?

@bradlarsen bradlarsen added the enhancement New feature or request label Feb 9, 2023
@bradlarsen
Copy link
Collaborator Author

Another GitHub Action that uses SARIF to share its findings: https://github.com/redhat-plumbers-in-action/differential-shellcheck

@bradlarsen bradlarsen added the integration Related to integration with other systems label Jun 14, 2023
@bradlarsen bradlarsen added the help wanted Extra attention is needed label Oct 16, 2023
@bpsizemore
Copy link

Hey @bradlarsen

I've created https://github.com/bpsizemore/noseyparker-action - we have just started integrating it into our private CI/CD flows. I'm happy to work with the Praetorian team to make any improvements or changes that make sense. I've tried to make it as flexible as possible and create a straightforward way to use custom rulesets to reduce noise.

@bradlarsen
Copy link
Collaborator Author

@bpsizemore That's great! Thanks for the pointer; I will take a closer look at what you've built.

Is this GitHub integration something you have any interest in incorporating upstream, or would you like to maintain it separately?

@bpsizemore
Copy link

Happy to incorporate it upstream if you guys want to move it into the noseyparker repo or into a separate Praetorian repo.

The docs on Github recommend keeping actions in a separate repository for readability and maintenance and if you want to publish it to the actions marketplace I believe you must have only one action per repository. I had toyed around with the idea of a "scan_local_repo" "scan_github_user" etc but if you wanted to build out more then you'd need to have a different repository per.

If you're developing an action for other people to use, we recommend keeping the action in its own repository instead of bundling it with other application code. This allows you to version, track, and release the action just like any other software.

Storing an action in its own repository makes it easier for the GitHub community to discover the action, narrows the scope of the code base for developers fixing issues and extending the action, and decouples the action's versioning from the versioning of other application code.

https://docs.github.com/en/actions/creating-actions/about-custom-actions#choosing-a-location-for-your-action

@bradlarsen
Copy link
Collaborator Author

@bpsizemore thanks for the pointer about GitHub Actions constraints — I wasn't aware of those restrictions.

Longer-term I am interested in making a GitHub Actions such as what you've written an official part of Nosey Parker. But no rush on that, as I'm currently backlogged with some other work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed integration Related to integration with other systems
Projects
None yet
Development

No branches or pull requests

2 participants