Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook fails when upgrading from ubuntu-22.04 to ubuntu-24.04 #214

Closed
epgui opened this issue Oct 11, 2024 · 2 comments
Closed

Hook fails when upgrading from ubuntu-22.04 to ubuntu-24.04 #214

epgui opened this issue Oct 11, 2024 · 2 comments

Comments

@epgui
Copy link

epgui commented Oct 11, 2024

I have the following Github Actions config:

  check-pre-commit-hooks:
    runs-on: ubuntu-22.04
    steps:
      - name: GitHub Checkout
        uses: actions/checkout@v4
      - name: Check other pre-commit hooks
        uses: pre-commit/[email protected]
        env:
          SKIP: no-commit-to-branch,terraform_fmt
        with:
          extra_args: --all-files --show-diff-on-failure

This runs successfully without problem. However, when I upgrade the ubuntu version as follows...

  check-pre-commit-hooks:
    runs-on: ubuntu-24.04
    # ...

... I get the following error:

Screenshot 2024-10-11 at 11 15 20 AM
@epgui
Copy link
Author

epgui commented Oct 11, 2024

Ah, it looks like the issue goes away when I add a actions/setup-python@v3 step as the documentation currently recommends.

@epgui epgui closed this as completed Oct 11, 2024
@asottile
Copy link
Member

asottile commented Oct 11, 2024

you are the third or fourth person to not search before creating an issue for this specific thing. please do better!

@pre-commit pre-commit locked as off-topic and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants