Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts with the Git deploy branch are difficult/impossible to resolve #523

Open
preaction opened this issue Dec 7, 2016 · 0 comments
Labels

Comments

@preaction
Copy link
Owner

If someone else has deployed the site since we've deployed it, we will not be allowed to push the deploy branch. We will instead be dropped on the deploy branch with an error message and barely told what to do.

Since I know what to do, I tried pulling, but the nature of the blog app basically means that every single merge will be a conflict. So, there was a conflict. I don't want to resolve the conflict, because I don't care what the site used to be: The deploy is completely re-building the site.

When using the git deploy, we should try to merge the remote deploy branch before building and committing. If this results in a conflict, we have two options:

  • If the deploy branch and development (starting) branch are the same, we can do nothing and must rely on the user to resolve the conflict. This is the safest option
  • If the deploy branch is different, we can simply clobber what's there and keep going.

We should add a safe flag to the Git deploy to prevent the clobbering behavior, and always ask the user for guidance on how to continue. This flag should be off by default.

@preaction preaction added the bug label Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant