You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
note: "In order to provide a fast and safe header bidding environment for publishers, the Prebid.org team reviews all adapters for the following required conventions:"
...
"No loading of external libraries: All code must be present in the adapter, not loaded at runtime."
I expect the Prebid.org team to "review all adapters for the following required convention:", including: "No loading of external libraries: All code must be present in the adapter, not loaded at runtime."
Actual results
The Criteo adapter appears to have been in violation for over a year.
Type of issue
BUG
Description
Criteo violates the required adapter conventions by loading external libraries
Steps to reproduce
...
"No loading of external libraries: All code must be present in the adapter, not loaded at runtime."
Test page
https://github.com/prebid/Prebid.js/blob/master/modules/criteoBidAdapter.js#L62
Expected results
I expect the Prebid.org team to "review all adapters for the following required convention:", including: "No loading of external libraries: All code must be present in the adapter, not loaded at runtime."
Actual results
The Criteo adapter appears to have been in violation for over a year.
Platform details
Other information
#2370
There was extensive discussion here and this same issue was raised. No answer was given.
@mkendall07
The text was updated successfully, but these errors were encountered: