Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quantcast adapter - Update all end points to https #4308

Closed
sumit116 opened this issue Oct 15, 2019 · 6 comments · Fixed by #4451
Closed

quantcast adapter - Update all end points to https #4308

sumit116 opened this issue Oct 15, 2019 · 6 comments · Fixed by #4451
Labels
adapter support pinned won't be closed by stalebot Prebid 3.0

Comments

@sumit116
Copy link
Contributor

Type of issue

Feature Request

Description

While doing an internal review for point 2 of the adapter’s section of http://prebid.org/blog/pbjs-3, I observed something unusual in your adapter. I saw more endpoints (test url) than the usual bid endpoint and usersync endpoint. Can you clarify on that all these endpoints are needed and whether they can be updated to https protocol or may be you can make the updates yourself?

Following change need to be addressed:

  • All the endpoints or any other thrid party urls used by the adapter needs to be updated to secure (https).

Platform details

Prebid 3.0

Other information

http://prebid.org/blog/pbjs-3

@sumit116
Copy link
Contributor Author

Hi @dpapworth-qc, can you check this issue?

@dpapworth-qc
Copy link
Contributor

👍 i will investigate this and make a PR the changes required for pbjs-3.

@stale
Copy link

stale bot commented Oct 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 29, 2019
@stale stale bot closed this as completed Nov 5, 2019
@dpapworth-qc
Copy link
Contributor

@sumit116 apologies for not looking at this. i am working on this now.

@sumit116 sumit116 removed the stale label Nov 11, 2019
@sumit116 sumit116 reopened this Nov 11, 2019
@sumit116 sumit116 added the pinned won't be closed by stalebot label Nov 11, 2019
@dpapworth-qc
Copy link
Contributor

@sumit116 added a PR, but the Rubicon merge (see #4449) is stopping all tests from executing.

@dpapworth-qc
Copy link
Contributor

Merged master, should be good for review and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapter support pinned won't be closed by stalebot Prebid 3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants