Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zedo adapter - Update all end points to https #4310

Closed
sumit116 opened this issue Oct 15, 2019 · 6 comments
Closed

zedo adapter - Update all end points to https #4310

sumit116 opened this issue Oct 15, 2019 · 6 comments

Comments

@sumit116
Copy link
Contributor

Type of issue

Improvement

Description

While doing an internal review for point 2 of the adapter’s section of http://prebid.org/blog/pbjs-3, I observed something unusual in your adapter. I saw secure and non-secure urls used for all endpoints and no protocol (http or https) is prefixed with the urls. Can you clarify on that all these endpoints are needed and whether they can be updated to https protocol or may be you can make the updates yourself?

Following change needs to be addressed:

  • All the endpoints or any other thrid party urls used by the adapter needs to be updated to secure (https).

Platform details

Prebid 3.0

Other information

http://prebid.org/blog/pbjs-3

@sumit116
Copy link
Contributor Author

Hi @skazedo , can you check this issue?

@stale
Copy link

stale bot commented Oct 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 29, 2019
@skazedo
Copy link
Contributor

skazedo commented Oct 29, 2019

@sumit116 - I have submitted a pull request for this. Can you check it. Thanks

@stale stale bot removed the stale label Oct 29, 2019
@stale
Copy link

stale bot commented Nov 12, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 12, 2019
@sumit116
Copy link
Contributor Author

@sumit116 - I have submitted a pull request for this. Can you check it. Thanks

Hi @skazedo, sorry I missed to read your comment. Can you share the PR link here?

@stale stale bot removed the stale label Nov 13, 2019
@skazedo
Copy link
Contributor

skazedo commented Nov 13, 2019

Here is the pull request - #4395. It has been merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants