Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

districtmdmx adapter - ensure adapter returns secure inventory only #4398

Closed
sumit116 opened this issue Oct 30, 2019 · 3 comments
Closed

districtmdmx adapter - ensure adapter returns secure inventory only #4398

sumit116 opened this issue Oct 30, 2019 · 3 comments
Labels
adapter support Prebid 3.0

Comments

@sumit116
Copy link
Contributor

sumit116 commented Oct 30, 2019 •
edited
Loading

Type of issue

bug

Description

Adapter passes secure field in request payload based on which adapter server might return insecure inventory if the field is set to false. So we should assign only true to
obj.secure = window.location.protocol === 'https:' ? 1 : 0; in districtmDMXBidAdapter.js.

Platform details

Prebid-3.0

Other information

#4294 (comment)
@sumit116 sumit116 mentioned this issue Oct 30, 2019
Merged
1 task
@jaiminpanchal27
Copy link
Collaborator

@stevealliance Can you review

@stevealliance
Copy link
Contributor

Ok I will open a PR can I send this to the current version of prebid? ... I believe you will use the same version since it will be compatible?

Thanks

@stevealliance
Copy link
Contributor

PR #4406 was closed and that update https was inforced!
@jaiminpanchal27 please closed this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
adapter support Prebid 3.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stevealliance @jaiminpanchal27 @sumit116