-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal - GPT Pre-Auction module #5216
Comments
is this related to line 39 here? https://github.com/prebid/Prebid.js/blob/master/modules/33acrossBidAdapter.js |
No - this is an evolution of http://prebid.org/features/pbAdSlot.html |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Ok, we need to hammer out the config for this. Here's a straw:
Notes:
|
@bretg I'd prefer to call it Also, a couple notes on the custom function params:
Does |
The pseudo-code I had in mind is basically the core of what PBJS does in targeting.setTargetingForGPT. In that context, the customSlotMatching functions have access to both the AdUnit and the proposed GPT slot
|
Assigning to @msm0504 as I believe he has begun the work |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Added a task to update the pbsBidAdapter so these values can make it server-side as well. |
This is a followup to the pbAdSlot feature covered in #4149
Background
PbAdSlot’s current solution solved the issue of publishers having no consistent inventory identifier passed to each bidder that can be used for reporting and deal targeting, but if there is a predefined value of 'pbadslot', the GAM ad unit is not also passed.
Problems to Solve
This update to PbAdSlot is attempting to solve the following:
Publishers passing PbAdSlot are not necessarily passing GAM ad unit
Proposal
We propose a new 'GPT Pre-Auction" module:
-ability to turn off module (on by default)
-customGptSlotMatching function
-customPbAdSlot function
-maps the adunit to the GPT slot using the same algorithm as setTargetingForGPTAsync including customGptSlotMatching
-if GPT slot matching succeeded:
--set fpd.context.adserver.name to 'gam'
--copy the resulting GPT slot name to fpd.context.adserver.adSlot
-if customPbAdSlot function was specified, invoke it, writing the results to fpd.context.pbAdSlot.
-Else use a default algorithm to determine fpd.context.pbAdSlot:
--First use the AdUnit's context.pbAdSlot if defined
--Else, see if the AdUnit.code corresponds to a div and if so, try to retrieve a data element from the div called data-adslotid.
--Else if the GPT slot matching succeeded, use the GPT slot name
--Else, just use the AdUnit.code, assuming that that's the ad unit slot
We also need to update the prebidServerBidAdapter to:
The text was updated successfully, but these errors were encountered: