-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional adUnit does not work in prebid video #5417
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi @fcurti, Can you please provide a test page, currently, I'm not able to reproduce the behaviour that you're talking about by visiting https://video.virgilio.it/. As far as I know, label should conditionally filter out the bidders which fail the label check, and this works for video as well. You can also try the new Advanced Size Mapping module, which makes this sort of setup a lot more intuitive. |
Hi @Fawke, Filtering for "ib.adnxs.com" on Network panel and navigate the "tag" object on Request Payload for this resource you wil find 2 configured Placement (1 for desktop, 1 for tablet mobile) I would expect to see only one tag on request Payload depending on device in use |
Hi @fcurti, I was able to reproduce the behaviour you're talking about. It seems that the "built in" For your use case, a new add-on module, Advanced Size Mapping is ideally suited. For example, if I convert the adUnit you've given the description to use Advanced Size Mapping, it'll look like this:
You can refer the documentation over here (Ctrl + f, "Using the Advanced Size Mapping Approach for Different Bidder Params") Let me know if you have any questions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I updated the docs to clarify that sizeConfig is banner-only. prebid/prebid.github.io#2191 |
Type of issue
BUG or Feature request
Description
The configuration of prebid video bidders using labelAny does not work.
The customSizeConfig is loaded in prebid
customSizeConfig:[
{
'mediaQuery': '(min-width: 1025px)',
'sizesSupported': [ [1800,1000],[1200,90],[970,250],[970,90],[728,90],[640,480],[300,600],[300,250],[100,200],[1,1] ],
'labels': ['desktop']
}, {
'mediaQuery': '(min-width: 766px) and (max-width: 1024px)',
'sizesSupported': [ [728,90],[640,480],[300,600],[300,250],[100,200],[1,1] ],
'labels': ['tablet']
}, {
'mediaQuery': '(min-width: 320px) and (max-width: 765px)',
'sizesSupported': [ [640,480],[300,600],[300,250],[300,50],[320,50],[320,100],[100,200],[1,1] ],
'labels': ['mobile']
}
]
The prebid video configuration has the labelAny setted
{
bidder : 'improvedigital',
labelAny : [ 'desktop' ],
params : {
placementId : thePlacementValueForDesktop
}
}, {
bidder : 'improvedigital',
labelAny : [ 'tablet', 'mobile' ],
params : {
placementId : thePlacementValueForTabletMobile
}
},
Steps to reproduce
Go to https://video.virgilio.it/ using desktop, check the prebid requests of some bidders.
The placementId of prebid request contains also the mobile placement id.
Test page
https://video.virgilio.it/
Expected results
Conditional adUnit should work fine also in prebid video
The text was updated successfully, but these errors were encountered: