Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional adUnit does not work in prebid video #5417

Closed
fcurti opened this issue Jun 25, 2020 · 6 comments
Closed

Conditional adUnit does not work in prebid video #5417

fcurti opened this issue Jun 25, 2020 · 6 comments
Assignees
Labels

Comments

@fcurti
Copy link

fcurti commented Jun 25, 2020

Type of issue

BUG or Feature request

Description

The configuration of prebid video bidders using labelAny does not work.
The customSizeConfig is loaded in prebid

customSizeConfig:[
{
'mediaQuery': '(min-width: 1025px)',
'sizesSupported': [ [1800,1000],[1200,90],[970,250],[970,90],[728,90],[640,480],[300,600],[300,250],[100,200],[1,1] ],
'labels': ['desktop']
}, {
'mediaQuery': '(min-width: 766px) and (max-width: 1024px)',
'sizesSupported': [ [728,90],[640,480],[300,600],[300,250],[100,200],[1,1] ],
'labels': ['tablet']
}, {
'mediaQuery': '(min-width: 320px) and (max-width: 765px)',
'sizesSupported': [ [640,480],[300,600],[300,250],[300,50],[320,50],[320,100],[100,200],[1,1] ],
'labels': ['mobile']
}
]

The prebid video configuration has the labelAny setted

{
bidder : 'improvedigital',
labelAny : [ 'desktop' ],
params : {
placementId : thePlacementValueForDesktop
}
}, {
bidder : 'improvedigital',
labelAny : [ 'tablet', 'mobile' ],
params : {
placementId : thePlacementValueForTabletMobile
}
},

Steps to reproduce

Go to https://video.virgilio.it/ using desktop, check the prebid requests of some bidders.
The placementId of prebid request contains also the mobile placement id.

Test page

https://video.virgilio.it/

Expected results

Conditional adUnit should work fine also in prebid video

@stale
Copy link

stale bot commented Jul 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 11, 2020
@Fawke Fawke self-assigned this Jul 13, 2020
@stale stale bot removed the stale label Jul 13, 2020
@Fawke
Copy link
Contributor

Fawke commented Jul 13, 2020

Hi @fcurti,

Can you please provide a test page, currently, I'm not able to reproduce the behaviour that you're talking about by visiting https://video.virgilio.it/.

As far as I know, label should conditionally filter out the bidders which fail the label check, and this works for video as well. You can also try the new Advanced Size Mapping module, which makes this sort of setup a lot more intuitive.

@fcurti
Copy link
Author

fcurti commented Jul 16, 2020

Hi @Fawke,
here you can find a test page with 2 placement AppNexus configured:
one is for Desktop (labelAny: 'desktop')
one is for Tablet/Mobile (labelAny: 'tablet, mobile')
https://www.iolam.it/test/video/appnexus.html

Filtering for "ib.adnxs.com" on Network panel and navigate the "tag" object on Request Payload for this resource you wil find 2 configured Placement (1 for desktop, 1 for tablet mobile)

I would expect to see only one tag on request Payload depending on device in use

@Fawke
Copy link
Contributor

Fawke commented Jul 17, 2020

Hi @fcurti,

I was able to reproduce the behaviour you're talking about. It seems that the "built in" sizeConfig feature in Prebid.js is limited and only works with banner mediaType and hence, you are not able to filter the bidders based on labels.

For your use case, a new add-on module, Advanced Size Mapping is ideally suited.

For example, if I convert the adUnit you've given the description to use Advanced Size Mapping, it'll look like this:

adUnits = [{
  code: 'ad-unit-1',
  mediaTypes: {
    video: {
      playerSize: [640, 480]
    }
  },
  bids: [{
    bidder: 'improvedigital',
    sizeConfig: [
      { minViewPort: [0, 0], relevantMediaTypes: ['none'] },
      { minViewPort: [1025, 0], relevantMediaTypes: ['video'] }
    ],
    params: {
       placementId : thePlacementValueForDesktop
    }
  }, {
   bidder: 'improvedigital',
   sizeConfig: [
     { minViewPort: [0, 0], relevantMediaTypes: ['none'] },       // between 0px and 320px, don't there is no relevant media type, hence, this bidder won't participate
     { minViewPort: [320, 0], relevantMediaTypes: ['video'] },    // between 320px and 1025px, we have "video" set as the relevant media type, hence this bidder will participate in the auction
     { minViewPort: [1025, 0], relevantMediaTypes: ['none'] }     // 1025px +, there is no active media type, so disable this bidder
   ],
   params : {
     placementId : thePlacementValueForTabletMobile
   }
  }]
}]

You can refer the documentation over here (Ctrl + f, "Using the Advanced Size Mapping Approach for Different Bidder Params")

Let me know if you have any questions.

@stale
Copy link

stale bot commented Aug 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 1, 2020
@bretg
Copy link
Collaborator

bretg commented Aug 6, 2020

I updated the docs to clarify that sizeConfig is banner-only. prebid/prebid.github.io#2191

@bretg bretg closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants