Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking used bids for video #5696

Closed
patmmccann opened this issue Sep 3, 2020 · 9 comments · Fixed by #8858
Closed

Marking used bids for video #5696

patmmccann opened this issue Sep 3, 2020 · 9 comments · Fixed by #8858
Labels

Comments

@patmmccann
Copy link
Collaborator

Type of issue

Feature request

Description

#5481 adds module support for detecting if a video bid won instead of just set targeting. #2777 adds a function for publishers to mark bids as used upon set targeting. It seems with the addition of #5481 that a logical extension of #2777 is to add MarkRenderedBidsAsUsed instead of mark winning bids as used. The logic might look very similar to mark winning but with the additional render check from #5481 . However, it isn't obvious how we would make a global function export like this depend on a module.

@pm-harshad-mane
Copy link
Contributor

@monis0395 / @monisq would you like to fix this too? It was dependent on your fix #5481

@monis0395
Copy link
Contributor

Hi @pm-harshad-mane, I am blocked for my sprint, will check after 9th October

@gglas
Copy link

gglas commented Mar 1, 2021

@monis0395 did you ever make any headway here? @karimMourra is this something easily addressed in the new video work we're doing?

@karimMourra
Copy link
Collaborator

@gglas I believe so. We would like the Video Module to emit ad rendering events such as adImpression which would indicate if the winning bid's ad creative was rendered.

@patmmccann
Copy link
Collaborator Author

will be addressed in #6271

@patmmccann
Copy link
Collaborator Author

@karimMourra should we re-open this or do we plan to put the video module stuff back up?

@patmmccann
Copy link
Collaborator Author

re-opening so i dont forget

@patmmccann patmmccann reopened this Aug 16, 2022
@karimMourra
Copy link
Collaborator

@patmmccann I reopened the PR ; we can keep this issue opened until the PR gets merged #8858

@patmmccann
Copy link
Collaborator Author

thanks!!

@patmmccann patmmccann linked a pull request Aug 17, 2022 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants