-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marking used bids for video #5696
Comments
@monis0395 / @monisq would you like to fix this too? It was dependent on your fix #5481 |
Hi @pm-harshad-mane, I am blocked for my sprint, will check after 9th October |
@monis0395 did you ever make any headway here? @karimMourra is this something easily addressed in the new video work we're doing? |
@gglas I believe so. We would like the Video Module to emit ad rendering events such as |
will be addressed in #6271 |
@karimMourra should we re-open this or do we plan to put the video module stuff back up? |
re-opening so i dont forget |
@patmmccann I reopened the PR ; we can keep this issue opened until the PR gets merged #8858 |
thanks!! |
Type of issue
Feature request
Description
#5481 adds module support for detecting if a video bid won instead of just set targeting. #2777 adds a function for publishers to mark bids as used upon set targeting. It seems with the addition of #5481 that a logical extension of #2777 is to add MarkRenderedBidsAsUsed instead of mark winning bids as used. The logic might look very similar to mark winning but with the additional render check from #5481 . However, it isn't obvious how we would make a global function export like this depend on a module.
The text was updated successfully, but these errors were encountered: