Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless Loop in ixBidAdapter with gdprEnforcement module and no consent for purpose 1 #7707

Closed
muuki88 opened this issue Nov 14, 2021 · 11 comments · Fixed by #7805
Closed

Endless Loop in ixBidAdapter with gdprEnforcement module and no consent for purpose 1 #7707

muuki88 opened this issue Nov 14, 2021 · 11 comments · Fixed by #7805
Assignees

Comments

@muuki88
Copy link
Collaborator

muuki88 commented Nov 14, 2021

Type of issue

Bug

Description

When upgrading to Prebid 6.1.0 index exchange runs into an endless loop when the gdprEnforcement module is enabled. I wasn't able to check if consent for purpose 1 is given or not, but I assume that it's not.

utils.js:272 Prebid ix ERROR: Error executing handler: events.js RangeError: Maximum call stack size exceeded
    at assign (<anonymous>)
    at _getConfig (config.js:317)
    at Object.getConfig (config.js:351)
    at debugTurnedOn (utils.js:299)
    at Module.logError (utils.js:271)
    at Module.<anonymous> (events.js:70)
    at Array.forEach (<anonymous>)
    at Module._each (utils.js:399)
    at _dispatch (events.js:65)
    at Object.module.exports._public.emit (events.js:99)

image

Steps to reproduce

I'm not 100% sure about those

  1. Upgrade to prebid 6.1.0
  2. Add gdprEnforcement module
  3. Don't consent to purpose 1

Test page

None.

Expected results

ixAdapter doesn't crash the page with an infinite loop.

Actual results

Chrome crashes

Platform details

  • Prebid 6.1.0
  • gdprEnforcement module enabled

Other information

@umakajan
Copy link
Contributor

Thanks @muuki88 for flagging this issue, will take it back to the development team and address the issue.

@muuki88
Copy link
Collaborator Author

muuki88 commented Nov 16, 2021

Do you still need a test page?

@gglas
Copy link

gglas commented Nov 22, 2021

@umakajan Hey guys -- how's progress coming along on this?

@lksharma
Copy link
Collaborator

Hey @gglas,
I am looking into this issue. @muuki88 would you be able to provide a test page for my reference?

@lksharma lksharma self-assigned this Nov 22, 2021
@muuki88
Copy link
Collaborator Author

muuki88 commented Nov 22, 2021

Okay. I'm on it. Will be tomorrow though 😄

@muuki88
Copy link
Collaborator Author

muuki88 commented Nov 23, 2021

Here it is @lksharma

https://frag-muki.de/ix-test/?pbjs_debug=true

Go to privacy settings and remove consent for purpose one. Take a look at the console.

@muuki88
Copy link
Collaborator Author

muuki88 commented Dec 2, 2021

@lksharma anything I can help you with?

@lksharma
Copy link
Collaborator

lksharma commented Dec 3, 2021

Hey @muuki88,

I was able to identify the issue and will be pushing my changes shortly. Once I have the branch ready would you be able to help verify against your test page?

@muuki88
Copy link
Collaborator Author

muuki88 commented Dec 3, 2021

Sure thing

@lksharma
Copy link
Collaborator

lksharma commented Dec 3, 2021

@muuki88 I pushed my changes here. I've verified the fix on my end. Let me know if you have any issues with your tests as well. Thank you.

@muuki88
Copy link
Collaborator Author

muuki88 commented Dec 6, 2021

@lksharma works 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants