-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intent To Implement: Transaction IDs Community Extension #8543
Comments
Let's go ahead and copy transaction id into source.tid as well while we're at it |
Interesting. Here's some context that may be helpful. Prebid.js currently supports the following:
The PBS Bid Adapter sets:
Is the thinking that PBJS-core (or the FPD Enrichment Module) would automatically add the PBJS transactionId to imp[].ext.tid? |
Hey @patmmccann and @bretg , I'm helping with implementing this extension and I actually have the same question as Bret. When exactly do we want to add tid? If ortb configs are configured by pubs? Or by default when PBJS core creates the transactionId and adds it to the adUnit? (https://github.com/prebid/Prebid.js/blob/master/src/prebid.js#L614). I also see there are two objects in bidderRequest, |
|
Went through #8562 and I think it makes sense for the "ortb validations and setting defaults" logic to be in one place. In my opinion, If the goal is to move enrichmentFpdModule.js logic to PBJS-core, it makes sense to set non-bidder specific fields such as Regarding Also, I think if we always set |
What is the meaning of I agree it makes sense to populate |
@robhazan - why does the proposal not go so far as to recommend different imp.ext.tid values? Isn't that more useful than the buyer receiving the same imp.ext.tid across multiple imps? Prebid could just use bidrequest.transactionId as separate UUIDs for each imp. |
My thinking was to allow the flexibility for multiple items in the impression array to be related to the same impression opportunity. So for a seller that doesn't support banner.format (for example), they could send an impression array with 2 items, each with different sizes, and the same tid. It's a 2.X community extension, so I didn't want to assume anything around the sophistication of the seller. |
IAB recently approved a new Community Extension to communicate transaction IDs in OpenRTB bid requests: https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/extensions/community_extensions/per-imp-tids.md
We propose to make a schema change to the ortb object in Prebid 7 to add imp[].ext.tid, which a number of adapters will begin to consume, to send per-impression-opportunity transactions IDs to bidders.
The text was updated successfully, but these errors were encountered: