Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Id Module not working with GDPR Enforcement module and prebid 7. #8647

Closed
newspassid-prebid opened this issue Jul 5, 2022 · 4 comments · Fixed by #8661
Closed

Shared Id Module not working with GDPR Enforcement module and prebid 7. #8647

newspassid-prebid opened this issue Jul 5, 2022 · 4 comments · Fixed by #8661
Assignees
Labels

Comments

@newspassid-prebid
Copy link
Contributor

Type of issue

Bug

Description

Shared Id Module not working with GDPR Enforcement module and prebid 7.

I'm working on some adapter updates for the ozone project and was reviewing some tests page I had created when I noticed the shared ID module isn't working / being set when used in conjunction with the GDPR Enforcement module and prebid 7 within the EU.

It looks like the GVLID for the sharedId module has been removed from its code in the

Steps to reproduce

(1) I've tried to use the shared ID and user ID modules with the latest prebid 7 code, GDPR Module and GDPR Enforcement module.
(2) Hit a page from within the EU using these modules - you'll notice shared ID isn't getting set.

Test page

Below are test pages that use the GDPR module and don't use the GDPR module.
Also makes no difference if you use local storage or cookie - but wanted to confirm that.

https://www.ardm.io/ozone/2.7.2/3-adslots-ozone-testpage-20220629-localstorage.html?pbjs_debug=true
https://www.ardm.io/ozone/2.7.2/3-adslots-ozone-testpage-20220629-cookie.html?pbjs_debug=true
https://www.ardm.io/ozone/2.7.2/3-adslots-ozone-testpage-20220629-localstorage-nogdpr.html?pbjs_debug=true
https://www.ardm.io/ozone/2.7.2/3-adslots-ozone-testpage-20220629-cookie-nogdpr.html?pbjs_debug=true

Expected results

Expect to see pubcid/shared ID in user object on all 4 pages.

Actual results

Expect to see pubcid/shared ID in user object on all 4 pages. You'll notice the first 2 pages which use GDPR enforcement fail.

Platform details

All

Other information

Pre-prebid 7 - the shared ID module included this snippet/line of code with the GVLID:
image

post prebid7 - this looks to have been updated/removed:
image

I don't know if the removal of const GVLID = 887 was intentional or not as part of prebid 7 but the GDPR enforcement module us trying to check the sharedIDs consent and look for a GVLID and doesn't find one so omits using it.

@patmmccann
Copy link
Collaborator

patmmccann commented Jul 5, 2022

This was intentional in #8448

Shared id is set by the pub, not prebid.org

In review feedback #8448 (comment) the committer tried to address this in tests i believe

@newspassid-prebid
Copy link
Contributor Author

thanks - if you check out the test page I put - I believe that has the latest code pulled last Tuesday - the enforcement module seems to be checking / looking for a GVLID still ?

Am I missing something on my side or is this a bug then as it doesn't sound like its intended behaviour ?

@dgirardi dgirardi self-assigned this Jul 5, 2022
@dgirardi dgirardi added the bug label Jul 5, 2022
@dgirardi
Copy link
Collaborator

dgirardi commented Jul 5, 2022

This is a bug - when coming from this path the logic still expects to have a gvlid.

@patmmccann
Copy link
Collaborator

patmmccann commented Jul 18, 2022

Fixed by #8661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
3 participants