From c2f20466eb83053c21d630acf8f6b8a280325b0a Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Thu, 25 Mar 2021 12:04:39 -0400 Subject: [PATCH 01/11] Update eids.js --- modules/userId/eids.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/userId/eids.js b/modules/userId/eids.js index 9b26eff2ebf..a0b19e884d5 100644 --- a/modules/userId/eids.js +++ b/modules/userId/eids.js @@ -93,7 +93,7 @@ const USER_IDS_CONFIG = { // britepoolId 'britepoolid': { source: 'britepool.com', - atype: 1 + atype: 3 }, // lotamePanoramaId @@ -111,7 +111,7 @@ const USER_IDS_CONFIG = { // merkleId 'merkleId': { source: 'merkleinc.com', - atype: 1 + atype: 3 }, // NetId @@ -161,7 +161,7 @@ const USER_IDS_CONFIG = { // Verizon Media ConnectID 'connectid': { source: 'verizonmedia.com', - atype: 1 + atype: 3 }, // Neustar Fabrick From c422dc9397df5880cc7c706f0de1f8923cf7506e Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Thu, 25 Mar 2021 12:18:31 -0400 Subject: [PATCH 02/11] Update eids_spec.js --- test/spec/modules/eids_spec.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/spec/modules/eids_spec.js b/test/spec/modules/eids_spec.js index 659e5257e90..61111dcd2cc 100644 --- a/test/spec/modules/eids_spec.js +++ b/test/spec/modules/eids_spec.js @@ -90,7 +90,7 @@ describe('eids array generation for known sub-modules', function() { expect(newEids.length).to.equal(1); expect(newEids[0]).to.deep.equal({ source: 'merkleinc.com', - uids: [{id: 'some-random-id-value', atype: 1}] + uids: [{id: 'some-random-id-value', atype: 3}] }); }); @@ -117,7 +117,7 @@ describe('eids array generation for known sub-modules', function() { expect(newEids.length).to.equal(1); expect(newEids[0]).to.deep.equal({ source: 'liveintent.com', - uids: [{id: 'some-random-id-value', atype: 1}], + uids: [{id: 'some-random-id-value', atype: 3}], ext: {segments: ['s1', 's2']} }); }); @@ -132,7 +132,7 @@ describe('eids array generation for known sub-modules', function() { expect(newEids.length).to.equal(1); expect(newEids[0]).to.deep.equal({ source: 'liveintent.com', - uids: [{id: 'some-random-id-value', atype: 1}] + uids: [{id: 'some-random-id-value', atype: 3}] }); }); @@ -144,7 +144,7 @@ describe('eids array generation for known sub-modules', function() { expect(newEids.length).to.equal(1); expect(newEids[0]).to.deep.equal({ source: 'britepool.com', - uids: [{id: 'some-random-id-value', atype: 1}] + uids: [{id: 'some-random-id-value', atype: 3}] }); }); From ec752ee2606911581555d4d570a0ffc32fff3b91 Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Thu, 25 Mar 2021 12:19:08 -0400 Subject: [PATCH 03/11] Update eids.js --- modules/userId/eids.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/userId/eids.js b/modules/userId/eids.js index a0b19e884d5..918035a177f 100644 --- a/modules/userId/eids.js +++ b/modules/userId/eids.js @@ -80,7 +80,7 @@ const USER_IDS_CONFIG = { return data.lipbid; }, source: 'liveintent.com', - atype: 1, + atype: 3, getEidExt: function(data) { if (Array.isArray(data.segments) && data.segments.length) { return { From ea44e2108c6070469c6ea2e76fae68e95300fa80 Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Thu, 25 Mar 2021 14:41:34 -0400 Subject: [PATCH 04/11] Update pubmaticBidAdapter_spec.js --- test/spec/modules/pubmaticBidAdapter_spec.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/spec/modules/pubmaticBidAdapter_spec.js b/test/spec/modules/pubmaticBidAdapter_spec.js index 09573fe9f85..4477ee4824f 100644 --- a/test/spec/modules/pubmaticBidAdapter_spec.js +++ b/test/spec/modules/pubmaticBidAdapter_spec.js @@ -1695,7 +1695,7 @@ describe('PubMatic adapter', function () { 'source': 'liveramp.com', 'uids': [{ 'id': 'identity-link-user-id', - 'atype': 1 + 'atype': 3 }] }]); }); @@ -1736,7 +1736,7 @@ describe('PubMatic adapter', function () { 'source': 'liveintent.com', 'uids': [{ 'id': 'live-intent-user-id', - 'atype': 1 + 'atype': 3 }] }]); }); @@ -1818,7 +1818,7 @@ describe('PubMatic adapter', function () { 'source': 'britepool.com', 'uids': [{ 'id': 'britepool-user-id', - 'atype': 1 + 'atype': 3 }] }]); }); From d44f2985f3f17e38b97ba790d807b1e802246b23 Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Thu, 25 Mar 2021 14:42:17 -0400 Subject: [PATCH 05/11] Update eids.js --- modules/userId/eids.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/userId/eids.js b/modules/userId/eids.js index 918035a177f..37cbd70af95 100644 --- a/modules/userId/eids.js +++ b/modules/userId/eids.js @@ -71,7 +71,7 @@ const USER_IDS_CONFIG = { // identityLink 'idl_env': { source: 'liveramp.com', - atype: 1 + atype: 3 }, // liveIntentId From 10efcdda8340343491aa5764113eee12bed40749 Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Thu, 25 Mar 2021 14:46:51 -0400 Subject: [PATCH 06/11] Update eids_spec.js --- test/spec/modules/eids_spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/spec/modules/eids_spec.js b/test/spec/modules/eids_spec.js index 61111dcd2cc..26e42e0ae2c 100644 --- a/test/spec/modules/eids_spec.js +++ b/test/spec/modules/eids_spec.js @@ -102,7 +102,7 @@ describe('eids array generation for known sub-modules', function() { expect(newEids.length).to.equal(1); expect(newEids[0]).to.deep.equal({ source: 'liveramp.com', - uids: [{id: 'some-random-id-value', atype: 1}] + uids: [{id: 'some-random-id-value', atype: 3}] }); }); From 78fb35f5c315e8e970b0a2570227a71791a37e87 Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Thu, 25 Mar 2021 14:48:00 -0400 Subject: [PATCH 07/11] Update conversantBidAdapter_spec.js --- test/spec/modules/conversantBidAdapter_spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/spec/modules/conversantBidAdapter_spec.js b/test/spec/modules/conversantBidAdapter_spec.js index d802cd288ef..0105626d97a 100644 --- a/test/spec/modules/conversantBidAdapter_spec.js +++ b/test/spec/modules/conversantBidAdapter_spec.js @@ -3,7 +3,7 @@ import {spec, storage} from 'modules/conversantBidAdapter.js'; import * as utils from 'src/utils.js'; import { createEidsArray } from 'modules/userId/eids.js'; -describe('Conversant adapter tests', function() { +describe('Conversant adapter tests', function() {/ const siteId = '108060'; const versionPattern = /^\d+\.\d+\.\d+(.)*$/; @@ -483,7 +483,7 @@ describe('Conversant adapter tests', function() { const payload = spec.buildRequests(requests).data; expect(payload).to.have.deep.nested.property('user.ext.eids', [ {source: 'adserver.org', uids: [{id: '223344', atype: 1, ext: {rtiPartner: 'TDID'}}]}, - {source: 'liveramp.com', uids: [{id: '334455', atype: 1}]} + {source: 'liveramp.com', uids: [{id: '334455', atype: 3}]} ]); }); }); From 5c082a1bbf1dc7fafb773082d3cbde18027ec8b8 Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Thu, 25 Mar 2021 14:51:03 -0400 Subject: [PATCH 08/11] Update rubiconBidAdapter_spec.js --- test/spec/modules/rubiconBidAdapter_spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/spec/modules/rubiconBidAdapter_spec.js b/test/spec/modules/rubiconBidAdapter_spec.js index 36890a2891b..0b9f8e0da33 100644 --- a/test/spec/modules/rubiconBidAdapter_spec.js +++ b/test/spec/modules/rubiconBidAdapter_spec.js @@ -1498,7 +1498,7 @@ describe('the rubicon adapter', function () { // LiveIntent should exist expect(post.user.ext.eids[0].source).to.equal('liveintent.com'); expect(post.user.ext.eids[0].uids[0].id).to.equal('0000-1111-2222-3333'); - expect(post.user.ext.eids[0].uids[0].atype).to.equal(1); + expect(post.user.ext.eids[0].uids[0].atype).to.equal(3); expect(post.user.ext.eids[0]).to.have.property('ext').that.is.an('object'); expect(post.user.ext.eids[0].ext).to.have.property('segments').that.is.an('array'); expect(post.user.ext.eids[0].ext.segments[0]).to.equal('segA'); @@ -1506,7 +1506,7 @@ describe('the rubicon adapter', function () { // LiveRamp should exist expect(post.user.ext.eids[1].source).to.equal('liveramp.com'); expect(post.user.ext.eids[1].uids[0].id).to.equal('1111-2222-3333-4444'); - expect(post.user.ext.eids[1].uids[0].atype).to.equal(1); + expect(post.user.ext.eids[1].uids[0].atype).to.equal(3); // SharedId should exist expect(post.user.ext.eids[2].source).to.equal('sharedid.org'); expect(post.user.ext.eids[2].uids[0].id).to.equal('1111'); From 09741b071988f31511bc02ea77563dfc4b60b5a4 Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Thu, 25 Mar 2021 14:51:40 -0400 Subject: [PATCH 09/11] Update conversantBidAdapter_spec.js --- test/spec/modules/conversantBidAdapter_spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/spec/modules/conversantBidAdapter_spec.js b/test/spec/modules/conversantBidAdapter_spec.js index 0105626d97a..1cb6bd6c6d6 100644 --- a/test/spec/modules/conversantBidAdapter_spec.js +++ b/test/spec/modules/conversantBidAdapter_spec.js @@ -3,7 +3,7 @@ import {spec, storage} from 'modules/conversantBidAdapter.js'; import * as utils from 'src/utils.js'; import { createEidsArray } from 'modules/userId/eids.js'; -describe('Conversant adapter tests', function() {/ +describe('Conversant adapter tests', function() { const siteId = '108060'; const versionPattern = /^\d+\.\d+\.\d+(.)*$/; From f42f6d8923f8294e3427f8f5bedbe36da2a57a2e Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Thu, 25 Mar 2021 14:54:49 -0400 Subject: [PATCH 10/11] Delete test/spec/adapters directory --- test/spec/adapters/adbutler_spec.js | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 test/spec/adapters/adbutler_spec.js diff --git a/test/spec/adapters/adbutler_spec.js b/test/spec/adapters/adbutler_spec.js deleted file mode 100644 index e69de29bb2d..00000000000 From 35de176af84f528c1ebc93894737fabd281fd2e5 Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Thu, 25 Mar 2021 15:00:25 -0400 Subject: [PATCH 11/11] Update userId_spec.js --- test/spec/modules/userId_spec.js | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/test/spec/modules/userId_spec.js b/test/spec/modules/userId_spec.js index 95279380232..a5f0c8c24b7 100644 --- a/test/spec/modules/userId_spec.js +++ b/test/spec/modules/userId_spec.js @@ -938,7 +938,7 @@ describe('User ID', function () { expect(bid.userId.idl_env).to.equal('AiGNC8Z5ONyZKSpIPf'); expect(bid.userIdAsEids[0]).to.deep.equal({ source: 'liveramp.com', - uids: [{id: 'AiGNC8Z5ONyZKSpIPf', atype: 1}] + uids: [{id: 'AiGNC8Z5ONyZKSpIPf', atype: 3}] }); }); }); @@ -962,7 +962,7 @@ describe('User ID', function () { expect(bid.userId.idl_env).to.equal('AiGNC8Z5ONyZKSpIPf'); expect(bid.userIdAsEids[0]).to.deep.equal({ source: 'liveramp.com', - uids: [{id: 'AiGNC8Z5ONyZKSpIPf', atype: 1}] + uids: [{id: 'AiGNC8Z5ONyZKSpIPf', atype: 3}] }); }); }); @@ -1032,7 +1032,7 @@ describe('User ID', function () { expect(bid.userId.lipb.lipbid).to.equal('random-ls-identifier'); expect(bid.userIdAsEids[0]).to.deep.equal({ source: 'liveintent.com', - uids: [{id: 'random-ls-identifier', atype: 1}] + uids: [{id: 'random-ls-identifier', atype: 3}] }); }); }); @@ -1056,7 +1056,7 @@ describe('User ID', function () { expect(bid.userId.lipb.lipbid).to.equal('random-cookie-identifier'); expect(bid.userIdAsEids[0]).to.deep.equal({ source: 'liveintent.com', - uids: [{id: 'random-cookie-identifier', atype: 1}] + uids: [{id: 'random-cookie-identifier', atype: 3}] }); }); }); @@ -1440,7 +1440,7 @@ describe('User ID', function () { expect(bid.userId.lipb.segments).to.include('123'); expect(bid.userIdAsEids[0]).to.deep.equal({ source: 'liveintent.com', - uids: [{id: 'random-ls-identifier', atype: 1}], + uids: [{id: 'random-ls-identifier', atype: 3}], ext: {segments: ['123']} }); }); @@ -1469,7 +1469,7 @@ describe('User ID', function () { expect(bid.userId.lipb.segments).to.include('123'); expect(bid.userIdAsEids[0]).to.deep.equal({ source: 'liveintent.com', - uids: [{id: 'random-cookie-identifier', atype: 1}], + uids: [{id: 'random-cookie-identifier', atype: 3}], ext: {segments: ['123']} }); }); @@ -1494,7 +1494,7 @@ describe('User ID', function () { expect(bid.userId.britepoolid).to.equal('279c0161-5152-487f-809e-05d7f7e653fd'); expect(bid.userIdAsEids[0]).to.deep.equal({ source: 'britepool.com', - uids: [{id: '279c0161-5152-487f-809e-05d7f7e653fd', atype: 1}] + uids: [{id: '279c0161-5152-487f-809e-05d7f7e653fd', atype: 3}] }); }); }); @@ -1592,7 +1592,7 @@ describe('User ID', function () { expect(bid.userId.merkleId).to.equal('testmerkleId'); expect(bid.userIdAsEids[0]).to.deep.equal({ source: 'merkleinc.com', - uids: [{id: 'testmerkleId', atype: 1}] + uids: [{id: 'testmerkleId', atype: 3}] }); }); });