Stored Requests by account id for filesystem

[muuki88]

In #488 stored request by account id where introduced, but as far as I understand this doesn't cover the filesystem stored requests implementation. Currently the configuration looks like this

settings:
  filesystem:
    stored-requests-dir: configs/stored-requests

A simple solution would be something like this

settings:
  filesystem:
    stored-requests-dir: configs/stored-requests
    appendAccountId: true

this wouldeffectively appending the accountId to the path. If a request has the accountId example.com
it would turn configs/stored-requests into configs/stored-requests/example.com.

FileApplicationSettings

prebid-server-java/src/main/java/org/prebid/server/settings/FileApplicationSettings.java

Lines 42 to 44 in a44b700

	private final Map<String, String> storedIdToRequest;
	private final Map<String, String> storedIdToImp;
	private final Map<String, String> storedIdToSeatBid;

Related

Relates to prebid/prebid-server#1024

[SerhiiNahornyi]

@muuki88 This feature with accountId was introduced, because it was a high chance of collision(mentioned in prebid/prebid-server#1024), but filesystem can not create this problem, because it can not be files with same name in same folder. We can add prefix to files with accountId, but could you please explain, is there a reason why we need this?

[muuki88]

@snahornyi you are right. This would just be for an "easier" to read structure in the filesystem.

Maybe if the ID contains slashes I can even workaround this 😂