Skip to content

Commit

Permalink
Breaking: bump node-abi so that Electron 14+ gets correct ABI (#161)
Browse files Browse the repository at this point in the history
electron/node-abi#113 was fixed in 3.3.0
and is affecting Electron 14+.

With the current node-abi prebuild-install will download ABI 89 for
electron 14 and 15 and then modules will fail to load as electron 14
has ABI 97 and electon 15 has ABI 98 in reality.

Drops support of Node.js < 10.
  • Loading branch information
csett86 authored Nov 12, 2021
1 parent c96c526 commit 477f347
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node: [6, 8, 10, 12, 14, 16]
node: [10, 12, 14, 16]
arch: [x64]
include:
- os: windows-latest
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"minimist": "^1.2.3",
"mkdirp-classic": "^0.5.3",
"napi-build-utils": "^1.0.1",
"node-abi": "^2.21.0",
"node-abi": "^3.3.0",
"npmlog": "^4.0.1",
"pump": "^3.0.0",
"rc": "^1.2.7",
Expand Down Expand Up @@ -64,6 +64,6 @@
},
"homepage": "https://github.com/prebuild/prebuild-install",
"engines": {
"node": ">=6"
"node": ">=10"
}
}

0 comments on commit 477f347

Please sign in to comment.