-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local prebuilds #137
Local prebuilds #137
Conversation
Please give any feedback, esp suggestions on how to fix the Windows + Node 10 error on AppVeyor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, the CI failure appears to have been temporary as it worked when re-run. I've left one comment inline but otherwise this is looks good to me.
Thanks for the review 👍 |
Hi, when can this PR be merged? I would need its functionality quite urgently. |
I don't have time to review and I'm on the fence about whether this feature is in scope, but this is a quality PR (has tests, good description, etc), I trust @lovell, and the upvotes indicate that multiple folks need this feature, so I'm merging and releasing. |
6.1.0 |
Signed-off-by: Timothy Johnson <[email protected]>
See #136 for discussion
Rationale
When an arch/platform/version does not have a published prebuild, we currently have two options:
node_config_${package}_binary_host
in the build environmentThis PR enables users to provide prebuilds via the host's filesystem.
Changes
--local-prebuilds
flag to specify prebuild dirnpm_config_${pkg.name}_local_prebuilds
env var to specify prebuild dirNotes
I mostly just re-added previously existing code. I also added:
prebuilds
dir