-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update node-abi so that electron 14+ get correct node-abi #161
Conversation
electron/node-abi#113 was fixed in 3.3.0 and is affecting electron 14+ With the current node-abi prebuild-install will download ABI 89 for electron 14 and 15 and then modules will fail to load as electron 14 has ABI 97 and electon 15 has ABI 98 in reality.
We'll need to drop support of Node < 10 because @prebuild/builders Thumbs up or down for dropping Node < 10? |
I would take the opportunity to also drop Node < 12, since it's not a maintained version anymore. If not, we'll need to update major version again in the future. |
That will happen in any case. If not for 12 then for 14 or 16. If there's no effort in supporting a version, as is the case with Node.js 12 atm, we can keep it. Doing it now doesn't save time and hurts folks that are behind the Node.js LTS schedule. |
node-abi 3.0.0 did so too
electron/node-abi#113 was fixed in 3.3.0
and is affecting electron 14+
With the current node-abi prebuild-install will download ABI 89 for
electron 14 and 15 and then modules will fail to load as electron 14
has ABI 97 and electon 15 has ABI 98 in reality.