Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that trigger_systemtest.py uses the correct branches #141

Open
BenjaminRodenberg opened this issue Dec 18, 2019 · 1 comment · May be fixed by #143
Open

Make sure that trigger_systemtest.py uses the correct branches #141

BenjaminRodenberg opened this issue Dec 18, 2019 · 1 comment · May be fixed by #143
Assignees
@BenjaminRodenberg
Labels
bug Something isn't working

Comments

@BenjaminRodenberg
Copy link
Member

trigger_systemtest.py currently always uses systemtests:master. This leads to failure of some tests (for example fenicsadapter triggers this test).

We need a way to specify the branch that trigger_systemtest.py should use (--branch argument that defaults to master) and automatically choose the correct branch in the repository that triggers the test.
@BenjaminRodenberg BenjaminRodenberg added the bug Something isn't working label Dec 18, 2019
@BenjaminRodenberg BenjaminRodenberg self-assigned this Dec 18, 2019
@BenjaminRodenberg
Copy link
Member Author

I started working on this issue on https://github.com/precice/systemtests/tree/i_141 and https://github.com/precice/fenics-adapter/tree/trigger_develop.

@BenjaminRodenberg BenjaminRodenberg linked a pull request Dec 19, 2019 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenjaminRodenberg BenjaminRodenberg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@BenjaminRodenberg