You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This will break git describe for detecting the preCICE revision. So either we accept it, or we accept the longer clone times for the preCICE library itself.
The text was updated successfully, but these errors were encountered:
This will break git describe for detecting the preCICE revision. So either we accept it, or we accept the longer clone times for the preCICE library itself.
Does this mean that the preCICE revision in the log will be missing? I think it is very useful to know the preCICE revision in the systemtests when trying to find bugs. Until we have a rigorous strategy for labelling the docker images themselves with the revision they contain (e.g. #138 or #193) I would vote against sacrificing the revision info in favour of quicker building.
The systemtests know which branch to checkout and don't need to access the git history.
Thus we can reduce the clone-time by using shallow git clones:
This will break
git describe
for detecting the preCICE revision. So either we accept it, or we accept the longer clone times for the preCICE library itself.The text was updated successfully, but these errors were encountered: