Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shallow git clones in tests #188

Open
fsimonis opened this issue Feb 26, 2020 · 2 comments
Open

Use shallow git clones in tests #188

fsimonis opened this issue Feb 26, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@fsimonis
Copy link
Member

fsimonis commented Feb 26, 2020

The systemtests know which branch to checkout and don't need to access the git history.

Thus we can reduce the clone-time by using shallow git clones:

git clone --depth 1 --branch <branch> <repository> <directory>

This will break git describe for detecting the preCICE revision. So either we accept it, or we accept the longer clone times for the preCICE library itself.

@fsimonis fsimonis added the enhancement New feature or request label Feb 26, 2020
@BenjaminRodenberg
Copy link
Member

BenjaminRodenberg commented Feb 26, 2020

This will break git describe for detecting the preCICE revision. So either we accept it, or we accept the longer clone times for the preCICE library itself.

Does this mean that the preCICE revision in the log will be missing? I think it is very useful to know the preCICE revision in the systemtests when trying to find bugs. Until we have a rigorous strategy for labelling the docker images themselves with the revision they contain (e.g. #138 or #193) I would vote against sacrificing the revision info in favour of quicker building.

@fsimonis
Copy link
Member Author

fsimonis commented Feb 26, 2020

The core library is a special case worth mentioning and I agree that the revision information should stay intakt.

All other git clones for adapters, bindings and tutorial data should be shallow though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants