Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion fails in nutils-of test #258

Open
Eder-K opened this issue Nov 7, 2020 · 3 comments · May be fixed by #259
Open

Assertion fails in nutils-of test #258

Eder-K opened this issue Nov 7, 2020 · 3 comments · May be fixed by #259

Comments

@Eder-K
Copy link
Contributor

Eder-K commented Nov 7, 2020

See https://travis-ci.org/github/precice/systemtests/jobs/742004326#L636. the openfoam participant crashes shortly after starting.

This error just started popping up, directly after the adapter was switched from using precice-ubuntu1804.home-develop to precice-ubuntu1804.package-develop.

@MakisH
Copy link
Member

MakisH commented Nov 7, 2020

This is the full message:

openfoam-adapter-outer    | ASSERTION FAILED
openfoam-adapter-outer    |   Location:          bool precice::xml::XMLTag::getBooleanAttributeValue(const string&) const
openfoam-adapter-outer    |   File:              /home/precice/precice/src/xml/XMLTag.cpp:133

and this is the origin:

https://github.com/precice/precice/blob/641e5057cb5d71d39ed43ae1dbc6af597b60bf52/src/xml/XMLTag.cpp#L133

Did anything change recently in the respective precice-config.xml?

@Eder-K
Copy link
Contributor Author

Eder-K commented Nov 9, 2020

Not on precice/tutorials, I can only assume this is entirely related to #256, which introduced the most recent change to the xml file:

s|\(\s\+\)\(</participant>\)|\1 <export:vtk directory="precice-output" />\n\1\2|g' \

Note that .home was unintentionally used instead of the intended .package image. This could explain why the error did not show up earlier.

@Eder-K Eder-K linked a pull request Nov 11, 2020 that will close this issue
@Eder-K
Copy link
Contributor Author

Eder-K commented Nov 12, 2020

I did find that the indentation of the inserted line was off by one space (the precice-config.xml for nutils-of uses a different indent size than other tests). However, this did not resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants