Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use VTK for comparing results #274

Open
BenjaminRodenberg opened this issue Jan 20, 2021 · 1 comment
Open

Use VTK for comparing results #274

BenjaminRodenberg opened this issue Jan 20, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@BenjaminRodenberg
Copy link
Member

Currently we use this script to compare the results. There are two problems:

  • Bash is hard to understand and debug (at least for me)
  • It does not compare the actual data, but the content of the files. If the format changes, but the data is still the same this is no regression, since we want to test the data and not the format. However, the tests will fail, since the files differ (e.g. Change "float" to "double" in reference output #273).

I would suggest to use VTK for comparing results. VTK is available in C++ and python. I have some limited experience with vtk in python and think this should be doable with a small python script using VTK. Noteworthy: VTK Is a more or less heavy dependency.
@BenjaminRodenberg BenjaminRodenberg added the enhancement New feature or request label Jan 20, 2021
@BenjaminRodenberg BenjaminRodenberg mentioned this issue Jan 20, 2021
Merged
@BenjaminRodenberg
Copy link
Member Author

#273 (review) reminds me of one case we cannot compare with vtk: comparing iteration numbers is actually quite nice for some cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BenjaminRodenberg