Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module 2: Capstone project #21

Open
preciousakams opened this issue May 23, 2022 · 2 comments
Open

Module 2: Capstone project #21

preciousakams opened this issue May 23, 2022 · 2 comments

Comments

@preciousakams
Copy link
Owner

https://github.com/kamzzy/PImovies/projects/1

We are 2 on this team

@danmainah
Copy link

Hi @Kamzzy and @IshmaelKargbo,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

✔️ Good design
✔️ Good issue with necessary information

Required Changes ♻️

  • Kindly ensure all tasks have been assigned, I can currently see tasks have not been assigned. Also, ensure cards are assigned in a fair way to team members

Optional suggestions

  • [OPTIONAL] It would be nice to add description of each cards task.

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@rotimiazeez
Copy link

Hi TEAM 😉,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants