Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify stricter database version #21

Open
martinheidegger opened this issue Jul 8, 2020 · 7 comments · May be fixed by #64
Open

Specify stricter database version #21

martinheidegger opened this issue Jul 8, 2020 · 7 comments · May be fixed by #64

Comments

@martinheidegger
Copy link

martinheidegger commented Jul 8, 2020

Currently the mysql database version is 5 which when resolved to 5.0 is certainly too low (it resolves to 5.7.30 at the time of writing). It would probably better to be stricter with the database version (maybe 5.7? or even with a patch version?) as it would reduce the amount possible bugs.

@MikkCZ
Copy link
Contributor

MikkCZ commented Mar 21, 2023

There was actually an opposite change made since this ticket was reported - 70ba542 set the database container to be used to mysql:latest.

@MikkCZ
Copy link
Contributor

MikkCZ commented Mar 21, 2023

Personally, I agree that the version should be stricter, if possible. At the same time, the Pretalx documentation says

We recommend using PostgreSQL. pretalx also works (and runs tests against) MariaDB and SQLite.

So it might be actually more appropriate to configure Postgres instead.

@rixx
Copy link
Member

rixx commented Mar 22, 2023

I have no opinion on this, and am happy to follow whatever people interested in using this dockerfile want – though it would seem to me that changing databases at this point would be a major step for people using this repo, and migrating from one to the other is nontrivial.

@almereyda
Copy link
Collaborator

I agree that following the upstream convention seems appropriate for a downstream project. If people need a derivation, they can always go down that path in our magnificient FLOSS land.

Did I understand this correctly: Changing the database (in the main compose.yaml manifest) for people using this repo being a major step implies that people update their local environments usually with git pull and docker compose up -d?

While the migration is not trivial, we can certainly provide different examples through well-documented compose.{postgres,mariadb,mysql}.yaml manifests.

For me this discussion correlates strongly with the observations and argument in #62 (comment) : with adopting more conventional patterns of handling a dockerized Django application, we can reduce the ambiguity for end users of this repository.

The migration path from MySQL to PostgreSQL could be transparent, when this initiative comes to terms:

The Future of MySQL is Postgres

Simplifying Migrations by Reimagining MySQL as a PostgreSQL Extension

Jonah Harris, Postgres Conference, 2024-04-19

@almereyda almereyda linked a pull request May 9, 2024 that will close this issue
@rixx
Copy link
Member

rixx commented Oct 28, 2024

Update: pretalx now requires postgreSQL or SQLite.

@martinheidegger
Copy link
Author

The legacy file should probably reflect that:

image: mysql:latest

But also considering the rework → #64 (cc. @almereyda) it may be good to be a bit more specific with the working postgres version (15 is quite broad still, though if postgres follows semver it should be fine)

@rixx
Copy link
Member

rixx commented Oct 29, 2024

PostgreSQL does not follow SemVer.

Just as a heads-up, my current impression is that this repo is in a permanently uncared-for / neigh-unusable state. If this doesn’t change by the end of the year, or at least looks like it’s likely to change by then, I’ll probably archive it. The whole “community maintained” is not really working out and leads to confusion and frustration when people come here under the impression they’ll be able to "just" run pretalx with docker, and then things don’t work or break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants