Don't change \n to an actual newline

[aboyton]

First up, awesome work on this project, I'm really excited. I seem to recall there was some discussion about this for JavaScript but I can't find the issue.

Right now this converts

$foo = "hello\nworld"

into

$foo = "hello
world"

Personally I think it is nicer to leave the \n alone.

[mgrip]

🙏 Thanks for finding these issues @aboyton! Keep em coming 😉

[aboyton]

No worries. Not sure how much time I'll have to help with the coding, but very happy to help with the testing. I've got a reasonably large PHP codebase to run this on.

[alexander-akait]

WIP

[alexander-akait]

@mgrip sorry, did not have time today, tomorrow I will do

[mgrip]

No worries, thanks!

[mgrip]

@evilebottnawi fixed with #136

[aboyton]

This still appears to be happening for me in certain cases, in particular if I have a variable directly in a string like below. I'm happy to open a new issue if you'd like.

printf("Query run in $queryTimeTaken seconds.\n");

[alexander-akait]

Done in #263