Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-stable formatting with a multi-line comment in a method chain #1420

Open
mharris-figma opened this issue Jan 24, 2024 · 1 comment
Open

Comments

@mharris-figma
Copy link

Using prettier 3.2.4 and version 4.0.4 of @pretter/plugin-ruby

The following code snippet:

invites =
  Invite
  .where(id: invite_ids)
  .where(redeemed_at: nil)
  # this is a
  # multi-line-comment
  .limit(20)

Gets formatted as:

invites =
  Invite
    .where(id: invite_ids)
    .where(redeemed_at: nil)# this is a
    # multi-line-comment
    .
    limit(20)

However, this formatting is unstable. When formatting is applied again, it changes to:

invites =
  Invite
    .where(id: invite_ids)
    .where(redeemed_at: nil) # this is a# multi-line-comment
    .
    limit(20)

And then an additional round of formatting results in:

invites =
  Invite
    .where(id: invite_ids)
    .where(redeemed_at: nil) # this is a# multi-line-comment
    .limit(20)

Which is finally stable.

In particular, I hit this when upgrading my codebase from version 1.6.1 of @pretter-plugin-ruby.

The original formatting seems the best?

@boris-petrov
Copy link
Contributor

The same is true for single-line comments as well. I just got bit by this.

Just a friendly ping to @kddnewton. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants