-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Semicolons setting is ignored #1088
Comments
This issue is closed because it does not match our issue template or include all the required information. Please read and follow the instructions and reopen. |
Ah it is by design The #1079 explains that. .editorconfig file existed and all prettier options in settings.json were ignored. BY DESIGN |
Sorry, the bot closed this issue by mistake. I had a typo in the config of the bot. But yes, this is by design. |
@ntotten no problem, but could you give it another thought? removing trailing semicolon is not possible with editorconfig file :/ editorconfig/editorconfig#331 You even said it's good idea to have .editorconfig but what I can do now? to remove semicolons? |
@freed00m add a prettier config file to the project. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
You must complete all steps in this checklist or the issue will be automatically closed.
Summary
Regresion from version 3.7.0, when I downgrade plugin, the option is honored and working as expected
Github Repository to Reproduce Issue
No need, open any TypeScript file and observe the inserion of semicolons.
also I use
"editor.formatOnSave": true,
but seems unrelatedSteps To Reproduce:
"prettier.semi": false,
in ~/.config/Code - OSS/User/settings.jsonExpected result
Honor the
"prettier.semi": false
, config option and do not add semicolonsActual result
The prettier see the semi config option being false but ignores it and put semicolons as if I set it to true
Additional information
This is a regression from 3.7.0 version of this plugin
It is similar issue as #1085
VS Code Version: 1.40.0-3
Prettier Extension Version: 3.8.0
OS and version: 5.3.12-1-MANJARO && Windows 10 1803
Prettier Log Output
The text was updated successfully, but these errors were encountered: