Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not properly resolving to locally installed version of prettier in package.json? #609

Closed
alexw10 opened this issue Oct 24, 2018 · 3 comments
Closed

Not properly resolving to locally installed version of prettier in package.json? #609

alexw10 opened this issue Oct 24, 2018 · 3 comments
Labels
locked Please open a new issue and fill out the template instead of commenting.

Comments

@alexw10
Copy link

alexw10 commented Oct 24, 2018 •
edited
Loading

I have a question regarding the extension, after it releases a new update how quick are you guys to update the extension to utilize the new version?

I also may not now how this works and maybe it doesn't need to be updated in the extension, and it simply will just work when they release the feature.
Let me know if this is true.

The reason I ask is that it looks like this feature is going to be done soon:
prettier/prettier#5259
Which handles HTML/Vue/Angular templates

It is something we desperately want.

Any information on this as in when you would be able to upgrade the vscode prettier extension to the latest so can utilize the new feature coming out?
@alexw10
Copy link
Author

alexw10 commented Oct 25, 2018 •
edited
Loading

It looks like this is turning into a bug please see:
prettier/prettier#5259 (comment)

Also the PR creator said:
prettier/prettier#5259 (comment)

It seems to not be taking in the local version that I installed to test out the in dev prettier version.

any ideas anyone?
@CiGit thoughts on this?

@alexw10 alexw10 changed the title Upgrading prettier? Not taking in local version of package.json prettier Oct 25, 2018
@alexw10 alexw10 changed the title Not taking in local version of package.json prettier Not properly resolving to locally installed version of prettier in package.json? Oct 25, 2018
@CiGit
Copy link
Member

CiGit commented Nov 8, 2018

It took us less than 24h to release 1.7.1 with prettier 1.15.1
It seems it depends a lot on myself as I'm the only one with publish rights still active.

We use local version but not on start. This means language supported are the ones our prettier knows.
See #395

@CiGit CiGit added the question label Nov 8, 2018
@ntotten ntotten added this to the Version 3.0 milestone Oct 21, 2019
@ntotten ntotten closed this as completed Oct 22, 2019
@ntotten ntotten removed this from the Version 3.0 milestone Oct 22, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked Please open a new issue and fill out the template instead of commenting. label Apr 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ntotten @CiGit @alexw10