Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade prettier to 1.15 #617

Closed
alexw10 opened this issue Nov 7, 2018 · 6 comments
Closed

Upgrade prettier to 1.15 #617

alexw10 opened this issue Nov 7, 2018 · 6 comments
Labels
locked Please open a new issue and fill out the template instead of commenting.

Comments

@alexw10
Copy link

alexw10 commented Nov 7, 2018

Prettier version 1.15 was just released which supports HTML, Vue, and Angular now which are highly anticipated. Can we get the extension updated?

https://prettier.io/blog/2018/11/07/1.15.0.html

@choyongjoon
Copy link

And please add support for HTML, Vue, Angular and MDX.

@kachkaev
Copy link
Member

kachkaev commented Nov 7, 2018

It might be rational to solve the problem of adding new extensions by implementing plugin support in general: #395

Every language in Prettier comes from a plugin, no matter if it’s a core one or a third party. Prettier CLI can provide the list of plugins and thus file extensions via --support-info. There also exists --file-info to help editors know if a given file can be formatted or not (eg on save)

Prettier for Atom has been supprting this approach for a few months, so they don’t need to do anything to let people start using 1.15 (if it is installed globally or as a project dependency).

@CalebKester
Copy link

https://github.com/prettier/prettier-vscode#prettier-resolution

It should use whatever you have installed in the project. However I'm still trying to get it to work in vuejs to format html. I'll let you know what i find.

@StevenSwitten
Copy link

1.7 is out

@CiGit CiGit closed this as completed Nov 8, 2018
@vielhuber
Copy link

Hmm, I have "prettier-vscode" v. 1.7.2 installed and locally inside the project 1.15.2.

But when I open a *.vue file, the part on top does not get linted.

Am I'm doing something wrong?

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked Please open a new issue and fill out the template instead of commenting. label Apr 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

7 participants