Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8.0 problem #705

Closed
pladaria opened this issue Jan 31, 2019 · 11 comments · Fixed by #706
Closed

1.8.0 problem #705

pladaria opened this issue Jan 31, 2019 · 11 comments · Fixed by #706
Labels
locked Please open a new issue and fill out the template instead of commenting.

Comments

@pladaria
Copy link

pladaria commented Jan 31, 2019

Latest version (1.8.0) is not working for me. Previous version (1.7.3) working fine.

$ code --version
1.30.2
61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8
x64

$ uname -a
Linux xtc 4.10.0-40-generic #44~16.04.1-Ubuntu SMP Thu Nov 9 15:37:44 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

Error message

31/1/2019 17:28:39:
-------------------
Couldn't resolve parser "babel"

.prettierrc

{
    "printWidth": 110,
    "tabWidth": 4,
    "singleQuote": true,
    "trailingComma": "es5",
    "bracketSpacing": false,
    "proseWrap": "always",
    "overrides": [
        {
            "files": "package.json",
            "options": {
                "printWidth": 250
            }
        },
        {
            "files": "*.md",
            "options": {
                "tabWidth": 2
            }
        }
    ]
}

First lines of .eslintrc (not sure if relevant)

root: true
parser: babel-eslint
settings:
    react:
    ...
@atabel
Copy link

atabel commented Jan 31, 2019

Same here.
v1.8.0: seems to work in Mac, but not in Linux
v1.7.3: works fine

@giannisp
Copy link

giannisp commented Jan 31, 2019

I had to update prettier to get it working.
Both on the project dependencies and the local global version (npm i -g prettier).

@felixakiragreen
Copy link

felixakiragreen commented Jan 31, 2019

Same issue here. But on Mac.

1.7.3 worked fine, 1.8.0 is broken. Output: Couldn't resolve parser "babel"

Already tried installing prettier & babel globally. And reinstalling prettier, babel, prettier-vscode.

code --version
1.30.2
61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8
x64

uname -a
Darwin Kazimir.local 18.2.0 Darwin Kernel Version 18.2.0: Mon Nov 12 20:24:46 PST 2018; root:xnu-4903.231.4~2/RELEASE_X86_64 x86_64

Edit: Not using prettier through a project's dependencies. Just generally for JS/TS files.

@francocorreasosa
Copy link

francocorreasosa commented Jan 31, 2019

Same, had to downgrade on Mac. Don't have prettier in the project, but globally.

@glebec
Copy link

glebec commented Jan 31, 2019

Had to downgrade to an earlier version (on MacOS 10.4), using the following steps:

Click to see outdated instructions, prefer using @francocorreasosa's tip below!
  1. Download version 1.7.2 as a VISX file
  2. In VSC, uninstall the Prettier extension
  3. CMD + SHIFT + P and type `VISX`, ENTER to select "…install from VISX"
  4. Select the downloaded file
  5. Reload VSC when it tells you to
  6. Voilà, it works again.

Note, you may or may not have to disable extension auto-updates to prevent the regression from coming back. I haven't checked that yet.

@francocorreasosa
Copy link

francocorreasosa commented Jan 31, 2019

@glebec you can also Install another version...

image

@glebec
Copy link

glebec commented Jan 31, 2019

HAH. That would have been good to know 5 minutes ago. 😆 Thanks!

@andrewtpoe
Copy link

1.8.0 is broken for me as well on mac. Same error.

@CiGit
Copy link
Member

CiGit commented Jan 31, 2019

getSupportInfo seems to lie :-)

A current workaround could be (I didn't tested it):
a prettier config file with

{ 
"overrides": [
    {
      "files": "*.js",
      "options": {
        "parser": "babylon"
      }
    }
  ]
}

This should force the parser to be "babylon"

@CiGit
Copy link
Member

CiGit commented Jan 31, 2019

Fixed in #706. Released in 1.8.1
Thanks @JHilker !

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked Please open a new issue and fill out the template instead of commenting. label Apr 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants