Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation "none" not working for p-skeleton #10026

Closed
ckkz-it opened this issue Mar 19, 2021 · 0 comments
Closed

Animation "none" not working for p-skeleton #10026

ckkz-it opened this issue Mar 19, 2021 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@ckkz-it
Copy link

ckkz-it commented Mar 19, 2021

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
When you set animation="none" for the p-skeleton component it doesn't work. It adds the wrong css class to the component, therefore animation isn't being disabled.

Expected behavior
Setting animation="none" to the p-skeleton component should disable animation.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?
It doesn't work like expected without a fix.

Please tell us about your environment:

  • Angular version: 11.0.9

  • PrimeNG version: 11.2.0

  • Browser: all

  • Language: all

Adding css class to a component

'p-skeleton-animation-none': this.animation === 'none'

The css class definition (mismatch)
.p-skeleton-none::after {

p-skeleton-animation-none !== p-animation-none

@yigitfindikli yigitfindikli added Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Mar 22, 2021
@yigitfindikli yigitfindikli added this to the 11.3.2 milestone Mar 22, 2021
@yigitfindikli yigitfindikli self-assigned this Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants