Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar - ngOnDestory throws an exception #10247

Closed
dloprodu opened this issue May 17, 2021 · 2 comments
Closed

Sidebar - ngOnDestory throws an exception #10247

dloprodu opened this issue May 17, 2021 · 2 comments
Assignees
Labels
LTS-FIXED-10.1.3 Fixed in PrimeNG LTS 10.1.3 LTS-FIXED-11.4.6 Fixed in PrimeNG LTS 11.4.6 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@dloprodu
Copy link

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
In version 11.4.1 and 11.4.2, the Sidebar componenet throws an exception on its ngOnDestory method when the appendTo input is defined.

image

  • Angular version: 11.2.4
  • PrimeNG version: 11.4.2
  • Browser: [all ]
  • Language: [TypeScript 4.0.2]

  • Node (for AoT issues): node --version =

@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label May 17, 2021
@yigitfindikli yigitfindikli added this to the 12.Future milestone May 17, 2021
@yigitfindikli yigitfindikli self-assigned this May 17, 2021
@yigitfindikli yigitfindikli modified the milestones: 12.Future, 12.0.0-rc.1 May 20, 2021
@jonnomk
Copy link

jonnomk commented Sep 30, 2021

Can this please be fixed for version 11? We can't upgrade Angular to 12 yet...

@yigitfindikli yigitfindikli added LTS-FIXED-11.4.6 Fixed in PrimeNG LTS 11.4.6 LTS-FIXED-10.1.3 Fixed in PrimeNG LTS 10.1.3 and removed LTS-PORTABLE labels Oct 1, 2021
@ShrihariMohan
Copy link

A simple hack I used for this we're using the drawyerVisible to show/hide the sidebar. The same goes for [appendTo] also.

<p-sidebar position="bottom" [appendTo]="drawyerVisible?'body':''"  [(visible)]="drawyerVisible" [showCloseIcon]="true">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-10.1.3 Fixed in PrimeNG LTS 10.1.3 LTS-FIXED-11.4.6 Fixed in PrimeNG LTS 11.4.6 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants