Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with p-float-label and p-dropdown if selected value is falsy, but neither null, nor undefined #10315

Closed
j-be opened this issue Jun 8, 2021 · 1 comment

Comments

@j-be
Copy link

j-be commented Jun 8, 2021

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)

https://github-fnjo2c.stackblitz.io

Current behavior

false and 0 are treated as empty.

Expected behavior

false and 0 are treated as themselves, and only null and undefined are treated as empty.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

This was introduced in 11.4.1 (all versions up to including 11.4.0 exhibit the expected behavior described above). As that is a minor version increment I suspect this is a regression, and not a feature.

Please tell us about your environment:

Whatever StackBlitz is running at the time of writing, so only putting it there for completeness sake. Locally discovered on:

  • Angular version: 11.2.14
  • PrimeNG version: >= 11.4.1
  • Browser: at least the following, all on Linux Mint 20, up to date with the respective official repo at the time of writing:
    • Firefox 89.0
    • Chromium 90.0.4430.212
    • Opera 76.0.4017.177
    • Microsoft Edge Version 92.0.902.8
  • Language: TypeScript 4.1.5
  • Node (for AoT issues): node --version = v15.12.0
@yigitfindikli yigitfindikli added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jun 9, 2021
@yigitfindikli
Copy link
Contributor

Duplicate #10245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants