Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown appendTo default changed to "body" in PrimeNG 12 #10751

Closed
Thorski opened this issue Oct 19, 2021 · 0 comments
Closed

Dropdown appendTo default changed to "body" in PrimeNG 12 #10751

Thorski opened this issue Oct 19, 2021 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@Thorski
Copy link

Thorski commented Oct 19, 2021

I'm submitting a ... (check one with "x")

[X ] bug report => Search github for a similar issue or PR before submitting

**Current behavior**
The p-dropdown documentation says appendTo default is "null"
In 12.0 the code has changed and in dropdown.ts has:
   @Input() appendTo: any = "body";
Previously the code was 
  @Input() appendTo: any;

This breaks several of our dropdowns.
I do not have an element handy which I can specify appendTo.  When it is body (the new default), it is hidden behind other elements.

I have worked around the problemd by specifying [appendTo]="null"
This seems to still work (reverting to old behavior).  

Revert the default to "null" as documented.
Else, If the default is now "body" then document that and also document if "null" is still supported.

* **Angular version:** 12.2.7
<!-- Check whether this is still an issue in the most recent Angular version -->

* **PrimeNG version:** 12.2.0, 12.2.1

@yigitfindikli yigitfindikli added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Oct 20, 2021
@yigitfindikli yigitfindikli added this to the 12.2.2 milestone Oct 20, 2021
@yigitfindikli yigitfindikli self-assigned this Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants