Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TableHeaderCheckbox is checked when the selection array is empty #11025

Closed
MrPollux opened this issue Jan 3, 2022 · 1 comment
Closed

TableHeaderCheckbox is checked when the selection array is empty #11025

MrPollux opened this issue Jan 3, 2022 · 1 comment
Assignees
@mertsincan
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
13.1.0

Comments

@MrPollux
Copy link

MrPollux commented Jan 3, 2022

primeng/src/app/components/table/table.ts

Line 4090 in 8e60cc4

return selectableVal && this.dt.selection && selectableVal.every(v => this.dt.selection.some(s => this.dt.equals(v, s)));

Cause:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/every
Note: Calling this method on an empty array will return true for any condition!
@mertsincan mertsincan self-assigned this Jan 3, 2022
@mertsincan mertsincan added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jan 3, 2022
@mertsincan mertsincan added this to the 13.0.5 milestone Jan 3, 2022
@mertsincan
Copy link
Member

Good catch! Thanks a lot!

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
13.1.0
Development

No branches or pull requests
2 participants
@mertsincan @MrPollux