-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p-table and p-menubar together: Regression 16.0.2 -> 16.1.0 #13405
Comments
Hi, Could you please share a Stackblitz reproducer? |
We're unable to replicate your issue, if you are able to create a reproducer by using PrimeNG Issue Template or add details please edit this issue. This issue will be closed if no activities in 20 days. |
@cetincakiroglu As mentioned in the submission I can not get 16.1.0 working on StackBlitz (I linked to the issue I'm having there). The PrimeNG suggested template is still using version 14 and this does not reproduce the issue. |
This issue has been automatically marked as stale. If this issue is still affecting you with the latest version, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize it yet. If you have any new additional information, please include it with your comment! |
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you for your understanding! |
Describe the bug
We have a
p-menubar
component, inside of a<ng-template pTemplate="caption">
, in ap-table
.The p-table has
selectionMode="multiple"
and allows the user to check off individual rows:[(selection)]="selectedExtensions"
We hook the
onRowSelect()
andonRowUnselect()
methods and create the menubar items, where some of their disabled properties is set by the number of selected rows:I can verify that in version 16.0.2 of PrimeNG, the menubar items properly enable/disable when checking off rows in the table.
In version 16.1.0 they do not.
I can not create a repro at this time as the PrimeNG template is out of date on StackBlitz and trying to bring it up to 16.1.0 results in a separate issue.
Environment
PrimeNG 16.1.0
Angular ~16.0.0
Reproducer
No response
Angular version
16.1.6
PrimeNG version
16.0.0
Build / Runtime
Angular CLI App
Language
TypeScript
Node version (for AoT issues node --version)
18.16.0
Browser(s)
No response
Steps to reproduce the behavior
Expected behavior
Items properly enable/disable based on selection count.
Actual behavior: Items remain disabled (initial state).
The text was updated successfully, but these errors were encountered: