Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataTable] Row selection focus styling issue #13617

Closed
atakantepe opened this issue Sep 5, 2023 · 2 comments
Closed

[DataTable] Row selection focus styling issue #13617

atakantepe opened this issue Sep 5, 2023 · 2 comments
Assignees
@SoyDiego
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
16.4.0

Comments

@atakantepe
Copy link
Member

Offset should be outline-offset: -0.15rem; like in the PrimeVue

image
image
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 5, 2023
@SoyDiego
Copy link
Contributor

SoyDiego commented Sep 5, 2023 •
edited
Loading

I can take it @atakantepe , can you assign me the issue, please?

Edit: This should be modify in the primeng-sass-theme project. I did a previous PR there and maybe you can accept too:
primefaces/primeng-sass-theme#39

@atakantepe atakantepe assigned atakantepe and SoyDiego and unassigned atakantepe Sep 5, 2023
@atakantepe atakantepe added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 5, 2023
This was referenced Sep 8, 2023
Merged
Merged
@SoyDiego
Copy link
Contributor

Hi @atakantepe @gucal, sorry for delay. I was in holidays ^^
I fixed the value in primeng-sass-theme. You can check here: primefaces/primeng-sass-theme#44

Thanks!

@cetincakiroglu cetincakiroglu added this to the 16.4.0 milestone Sep 26, 2023
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Sep 26, 2023
@cetincakiroglu cetincakiroglu mentioned this issue Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoyDiego SoyDiego

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
16.4.0
Development

No branches or pull requests
3 participants
@SoyDiego @atakantepe @cetincakiroglu