Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Dark themes are broken #13786

Closed
SoyDiego opened this issue Sep 30, 2023 · 3 comments
Closed

Editor: Dark themes are broken #13786

SoyDiego opened this issue Sep 30, 2023 · 3 comments

Comments

@SoyDiego
Copy link
Contributor

SoyDiego commented Sep 30, 2023

Describe the bug

image

Environment

Reproducer

No response

Angular version

Last version

PrimeNG version

Last version

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.5.1

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://primeng.org/editor
  2. Change to a theme dark mode
  3. Try to open options in editor

Expected behavior

Show the correct color.

@SoyDiego SoyDiego added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 30, 2023
@SoyDiego
Copy link
Contributor Author

SoyDiego commented Oct 2, 2023

I wonder did someone even test these changes on Angular 16 in the PrimeNG team. I love PrimeNG, it's by far best angular UI library, but work done in last months with accessibility is unacceptable.

@SoyDiego you're a PrimeNG freak, could you help me with one thing please? Can you try testing ContextMenu p-contextMenu component on PrimeNG 16.3.1 or PrimeNG 16.4.0: try routing to another page on clicking on one ContextMenu item - it does NOT work properly to me. ContextMenu is not removed from the DOM after we route to another page in the Angular app.

Please create a issue or write your problem here https://github.com/orgs/primefaces/discussions/categories/primeng adding stackblitz example.

@SoyDiego
Copy link
Contributor Author

SoyDiego commented Oct 2, 2023

@SoyDiego could you please tell me what's difference between opening an issue here in the Issue tracker and opening a Discussion in the link you've sent? Discussion item's purpose to open is when we're not 100% sure that some issue is persistent?

The difference is that you are writing in the wrong place. On an issue that has nothing to do with your problem and you are mixing things up. The issue that I generated has to do with EDITOR Component and you are talking about ContextMenu and Menu.
If you have any questions about how something works, it is better to write in the place indicated, but do what you want, it will be more difficult to find the answer you want here.

@cetincakiroglu
Copy link
Contributor

Fixed in here 64dc786

Related to #13831

@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants